Skip to content

Handle PATs UI loading states #14944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14280
easyCZ opened this issue Nov 25, 2022 · 4 comments · Fixed by #15015
Closed
Tracked by #14280

Handle PATs UI loading states #14944

easyCZ opened this issue Nov 25, 2022 · 4 comments · Fixed by #15015
Labels
feature: public-api Issues relating to Public API team: webapp Issue belongs to the WebApp team

Comments

@easyCZ
Copy link
Member

easyCZ commented Nov 25, 2022

When we're loading PATs (either List, Get, Create etc), add a loading screen transition.

@easyCZ easyCZ added team: webapp Issue belongs to the WebApp team feature: public-api Issues relating to Public API labels Nov 25, 2022
@easyCZ easyCZ moved this to Scheduled in 🍎 WebApp Team Nov 28, 2022
@jeanp413
Copy link
Member

@gtsiolis is there a mockup for this?

@gtsiolis
Copy link
Contributor

@jeanp413 No, but I'm not sure how much needed is this for this iteration. The dashboard is running into this interaction issue also when loading other pages like variables, etc. @easyCZ Is this something we'd like to work on now?

If yes, a good MVC solution for this could be to re-use the same loading pattern with the spinner we use for loading branches and prebuilds lists, see screenshots below.

Branches ✔️ Prebuilds ✔️ Tokens 🚧
gitpod io_t_gitpod_gitpod gitpod io_t_gitpod_gitpod_prebuilds (1) Screenshot 2022-11-28 at 9 09 46 PM (2)

@easyCZ
Copy link
Member Author

easyCZ commented Nov 28, 2022

@gtsiolis Yes, indeed. It's scheduled in the current iteration.

And exactly as @gtsiolis suggested, nothing new or special is needed here, just showing something while the requests are pending. That goes for all the actions - loading the list, creating a token, etc..

@mustard-mh mustard-mh mentioned this issue Nov 30, 2022
4 tasks
@mustard-mh
Copy link
Contributor

Added component Loader.tsx with SpinnerLoader and SpinnerOverlayLoader

SpinnerLoader SpinnerOverlayLoader
image image

Repository owner moved this from Scheduled to In Validation in 🍎 WebApp Team Dec 1, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: public-api Issues relating to Public API team: webapp Issue belongs to the WebApp team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants