Skip to content

Make the 'Run Prebuild' button more consistent #15144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14969 ...
jankeromnes opened this issue Dec 5, 2022 · 0 comments · Fixed by #15147
Closed
Tracked by #14969 ...

Make the 'Run Prebuild' button more consistent #15144

jankeromnes opened this issue Dec 5, 2022 · 0 comments · Fixed by #15147
Assignees
Labels
team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

Is your feature request related to a problem? Please describe

Currently, Gitpod only accepts to run a prebuild for a commit that:

  • Belongs to a repository for which a Gitpod Project exists
  • Does not already have a successful prebuild associated

The problem is with the definition of "successful" -- Gitpod currently allows re-running prebuilds that failed due to system reasons (e.g. timed out), but not prebuilds that finished "successfully" but their init task finished with a non-zero error code (shown as "failed" in the UI, but not re-runnable, which is confusing).

Also, in general, making the 'Run Prebuild' action conditional makes the UX confusing: The 'Run Prebuild' action is seen as inconsistent and unreliable (sometimes it does something, sometimes it refuses).

Describe the behaviour you'd like

To fix this confusing situation, we could:

  • Always offer the 'Run Prebuild' / 'Re-run Prebuild' action, regardless of what state other prebuild are or aren't in

Describe alternatives you've considered

Additional context

There might be a few side effects to allowing multiple (potentially "successful") prebuilds for a single commit. However, we're pretty sure that we can handle those separately, and most of the system already supports multiple prebuilds for a single commit (e.g. multiple failed ones and one "successful" one).

@jankeromnes jankeromnes added type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Dec 5, 2022
@jankeromnes jankeromnes moved this to Scheduled in 🍎 WebApp Team Dec 5, 2022
@jankeromnes jankeromnes self-assigned this Dec 5, 2022
@jankeromnes jankeromnes moved this from Scheduled to In Progress in 🍎 WebApp Team Dec 5, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Dec 6, 2022
@jankeromnes jankeromnes moved this from In Validation to Done in 🍎 WebApp Team Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant