-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Description
Description
This conversation started here. Also see this Internal discussion that the following logic is does not anymore:
Lines 33 to 39 in 478a75e
if (result.resetTimeoutOnWorkspaces.isNotEmpty()) { | |
message = "Workspace timeout has been extended to three hours. This reset the workspace timeout for other workspaces." | |
notificationType = NotificationType.WARNING | |
} else { | |
message = "Workspace timeout has been extended to three hours." | |
notificationType = NotificationType.INFORMATION | |
} |
And, This reset the workspace timeout for other workspaces.
is not true. & It is also weird that it returns the current workspace in reset list:
gitpod/components/server/ee/src/workspace/gitpod-server-impl.ts
Lines 387 to 407 in 81e0623
const workspace = await this.internalGetWorkspace(workspaceId, this.workspaceDb.trace(ctx)); | |
const runningInstances = await this.workspaceDb.trace(ctx).findRegularRunningInstances(user.id); | |
const runningInstance = runningInstances.find((i) => i.workspaceId === workspaceId); | |
if (!runningInstance) { | |
throw new ResponseError(ErrorCodes.NOT_FOUND, "Can only set keep-alive for running workspaces"); | |
} | |
await this.guardAccess({ kind: "workspaceInstance", subject: runningInstance, workspace: workspace }, "update"); | |
const client = await this.workspaceManagerClientProvider.get( | |
runningInstance.region, | |
this.config.installationShortname, | |
); | |
const req = new SetTimeoutRequest(); | |
req.setId(runningInstance.id); | |
req.setDuration(validatedDuration); | |
await client.setTimeout(ctx, req); | |
return { | |
resetTimeoutOnWorkspaces: [workspace.id], | |
}; |
Also, Related #16083
Action Item
Remove & Update this logic
Metadata
Metadata
Assignees
Type
Projects
Status
Done