-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Two different errors with very similar PRs containing simple static sites #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Cervator!
You are absolutely right. Gitpod couldn't provide you with a ready-to-use workspace, because the remote branch from the PR ☝️ was already deleted. To continue working on the changes from that PR, please start from the target branch.
There is no doubt about it, no one can tell that from the error message. We definitely need to improve the handling in cases like this. Creating a workspace for the target branch could be another option. |
@Cervator, I left a comment on the Docker image PR: DestinationSol/DestinationSol.github.io#28 (comment) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Thanks again for this report!
This happens when the underlying branch or fork has been deleted. Now tracked here: #3659
This seems unrelated, and is probably a Dockerfile error. Seems to be addressed by DestinationSol/DestinationSol.github.io#28 (comment) |
Describe the bug
We set up with some GitPod config a little while ago. We had it working for both https://github.com/MovingBlocks/movingblocks.github.com and https://github.com/MovingBlocks/Terasology although in the latter case 1 FPS might be a generous description of "working" although that's from running a video game in a cloud workspace, not a problem with what GitPod wraps around our stuff 😅
However, now MovingBlocks/movingblocks.github.com#150 got one error immediately:
I realize that PR is closed and the associated branch has been deleted, which I would guess is probably the cause for the error. The same button on https://github.com/MovingBlocks/movingblocks.github.com seemingly works fine. But in that case shouldn't the UI produce a graceful error message to the user / prevent starting a workspace at all? The content is still there, although it looks like it was a squash merge.
Additionally DestinationSol/DestinationSol.github.io#28 does get past that error, but then fails while doing some Docker stuff. Similar simple static site, but the PR itself notes it did not actually work back when we tried it. Unsure if that was the same error as we're facing now:
(Manually typed, can't seem to copy paste from the error page)
The config files in that repo look identical to the ones in the movingblocks.github.com repo, that seemingly works (outside of that listed PR)
Steps to reproduce
Expected behavior
Expected the GitPod build would execute, work, and serve a workspace with the static site working, as it has in the past. Or at least serve more user-actionable errors :-)
Additional information
Inlined logs above
Example repository
Noted above
The text was updated successfully, but these errors were encountered: