Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when someone tries to open a merged PR with deleted branch #3659

Closed
filiptronicek opened this issue Mar 30, 2021 · 2 comments
Closed

Improve error message when someone tries to open a merged PR with deleted branch #3659

filiptronicek opened this issue Mar 30, 2021 · 2 comments
Assignees
@jankeromnes
Labels
type: improvement Improves an existing feature or existing code user experience

Comments

@filiptronicek
Copy link
Member

Bug description

When I tried opening a pull request which had its branch already merged and deleted, I got an error that really left me wondering what really happened.

Steps to reproduce

  1. Go to a merged PR with a deleted branch
  2. Open the URL with GitPod
  3. See the error (attached in my comment)
    Error: Cannot read property 'repository' of null

Expected behavior

Perhaps something like "couldn't find that branch in this repo, it's been probably deleted!

Example repository

More of an example Pull Request, here is one: #3431

image
@corneliusludmann corneliusludmann added the type: improvement Improves an existing feature or existing code label Mar 30, 2021
@corneliusludmann corneliusludmann changed the title Unexpected Error: We are having trouble parsing your context Improve error message when someone tries to open a merged PR with deleted branch Mar 30, 2021
@jankeromnes jankeromnes mentioned this issue Apr 1, 2021
Closed
9 tasks
@jankeromnes
Copy link
Contributor

I agree that Gitpod should show a better error message here, so I'll try to fix it.

Also, fun fact, this bug was originally reported as #4

@jankeromnes jankeromnes self-assigned this Apr 9, 2021
This was referenced Apr 9, 2021
Closed
Closed
@jankeromnes jankeromnes mentioned this issue Apr 9, 2021
Merged
jankeromnes added a commit that referenced this issue Apr 9, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
2ecf52f 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
jankeromnes added a commit that referenced this issue Apr 12, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
c014522 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
jankeromnes added a commit that referenced this issue Apr 12, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
3dbb050 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
@jankeromnes
Copy link
Contributor

Fixed in #3869, will go live with the next deployment.

MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Aug 9, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
79924b0 
…branch

Fixes #4 gitpod-io#321 gitpod-io#802 gitpod-io#1375 gitpod-io#3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
@jankeromnes jankeromnes mentioned this issue Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankeromnes jankeromnes

Labels
type: improvement Improves an existing feature or existing code user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gtsiolis @jankeromnes @corneliusludmann @filiptronicek