Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-helpful error message when the fork of a PR has been deleted #1375

Closed
spoenemann opened this issue Apr 8, 2020 · 4 comments
Closed

Non-helpful error message when the fork of a PR has been deleted #1375

spoenemann opened this issue Apr 8, 2020 · 4 comments
Labels
meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working user experience

Comments

@spoenemann
Copy link
Contributor

Describe the bug

When you open a PR in Gitpod that was created from a fork, and the fork is deleted again, Gitpod displays

We are having trouble parsing your context
Error: Cannot read property ‘repository’ of null

Steps to reproduce

  • Fork a repository
  • Create a PR to the original repository
  • Delete the fork
  • Open the PR in Gitpod

Expected behavior

The error message should make clear that the repository does not exist.

Example repository

eclipse/openvsx#61
@jankeromnes
Copy link
Contributor

I very much agree that this error message is super unhelpful.

Originally reported as #4

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 4, 2020
@svenefftinge svenefftinge added type: bug Something isn't working user experience and removed meta: stale This issue/PR is stale and will be closed soon labels Oct 5, 2020
@stale
Copy link

stale bot commented Mar 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 17, 2021
@stale stale bot closed this as completed Mar 27, 2021
@jankeromnes
Copy link
Contributor

Now being tracked here: #3659

@jankeromnes jankeromnes mentioned this issue Apr 9, 2021
Merged
jankeromnes added a commit that referenced this issue Apr 9, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
2ecf52f 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
jankeromnes added a commit that referenced this issue Apr 12, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
c014522 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
jankeromnes added a commit that referenced this issue Apr 12, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
3dbb050 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Aug 9, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
79924b0 
…branch

Fixes #4 gitpod-io#321 gitpod-io#802 gitpod-io#1375 gitpod-io#3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@svenefftinge @jankeromnes @spoenemann