Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle old PRs with deleted branches. #4

Closed
marcdumais-work opened this issue May 10, 2018 · 2 comments · Fixed by #3869
Closed

Handle old PRs with deleted branches. #4

marcdumais-work opened this issue May 10, 2018 · 2 comments · Fixed by #3869
Labels
meta: stale This issue/PR is stale and will be closed soon user experience

Comments

@marcdumais-work
Copy link

For a non-obvious reason, trying to review code from PR 1855, resulted in an instance where the source code was not cloned. In consequence, directory /workspace/ was empty and no workspace was set. I just tried with a different PR, and this did not happen.
@svenefftinge
Copy link
Member

I think this happened because the branch was deleted already. We need to detect that and tell the user.

@svenefftinge svenefftinge changed the title PR code not cloned Handle old PRs with deleted branches. Jun 22, 2018
@AlexTugarev AlexTugarev mentioned this issue Feb 20, 2019
Closed
@jankeromnes jankeromnes mentioned this issue Sep 23, 2019
Closed
@jankeromnes jankeromnes mentioned this issue Apr 8, 2020
Closed
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 4, 2020
fullmetalrooster pushed a commit that referenced this issue Feb 16, 2021
# This is a combination of 8 commits.
86e7486 
# This is the 1st commit message:

dev

# This is the commit message #2:

dev

# This is the commit message #3:

dev

# This is the commit message #4:

dev

# This is the commit message #5:

dev

# This is the commit message #6:

dev

# This is the commit message #7:

dev

# This is the commit message #8:

dev
@stale stale bot closed this as completed Mar 18, 2021
@jankeromnes jankeromnes mentioned this issue Apr 9, 2021
Closed
@jankeromnes jankeromnes mentioned this issue Apr 9, 2021
Merged
jankeromnes added a commit that referenced this issue Apr 9, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
2ecf52f 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
jankeromnes added a commit that referenced this issue Apr 12, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
c014522 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
jankeromnes added a commit that referenced this issue Apr 12, 2021
@jankeromnes
[server] Improve error message when trying to open a PR with deleted …
3dbb050 
…branch

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244
@akosyakov akosyakov mentioned this issue Jul 13, 2021
Merged
1 task
@blockchainguy1 blockchainguy1 mentioned this issue Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: stale This issue/PR is stale and will be closed soon user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[server] Improve error message when trying to open a PR with deleted branch gitpod-io/gitpod
3 participants
@svenefftinge @jankeromnes @marcdumais-work