Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] support "Share Running Workspace" #2812

Closed
akosyakov opened this issue Jan 11, 2021 · 3 comments · Fixed by #4580
Closed

[code] support "Share Running Workspace" #2812

akosyakov opened this issue Jan 11, 2021 · 3 comments · Fixed by #4580
Assignees
@akosyakov
Labels
editor: code (browser) roadmap item: gitpod code https://bit.ly/3oqjuOn type: feature request New feature or request
Milestone
[backlog] June 2021

Comments

@akosyakov
Copy link
Member

It should be possible to share running workspaces from Code.
@csweichel csweichel added the roadmap item: gitpod code https://bit.ly/3oqjuOn label Jan 12, 2021
@akosyakov akosyakov mentioned this issue Jan 28, 2021
Closed
@akosyakov akosyakov added this to the March 2021 milestone Jan 28, 2021
@svenefftinge svenefftinge changed the title [code] support running worskpaces [code] support "Share Running Workspace" Feb 1, 2021
@akosyakov akosyakov modified the milestones: March 2021, February 2021 Feb 1, 2021
@akosyakov akosyakov self-assigned this Feb 23, 2021
@akosyakov akosyakov modified the milestones: February 2021, March 2021 Feb 25, 2021
@akosyakov
Copy link
Member Author

I moved it to March. We should first sort out Gitpod API access tokens otherwise we can leak user data of owner to invited users.

@csweichel
Copy link
Contributor

I don't think we can do this in March. From a product perspective we first have to think through how we want this feature to behave. From a technical perspective, we need to figure out how we want to handle tokens/access in a shared workspace.

@csweichel csweichel removed this from the [backlog] March 2021 milestone Mar 1, 2021
@akosyakov akosyakov added this to the May 2021 (backlog) milestone Apr 13, 2021
@svenefftinge
Copy link
Member

I think we should add the action to share/unshare to e.g. to the toolbar. You can share workspaces from the dashboard already anyhow. That said we should redesign and rethink the whole sharing mechanic, but I think in the meantime we can just add that command.

@gtsiolis gtsiolis mentioned this issue Apr 29, 2021
Open
@akosyakov akosyakov removed their assignment Apr 29, 2021
@csweichel csweichel removed this from the May 2021 (backlog) milestone May 6, 2021
@akosyakov akosyakov self-assigned this Jun 7, 2021
@akosyakov akosyakov added this to the [backlog] June 2021 milestone Jun 7, 2021
@akosyakov akosyakov mentioned this issue Jun 23, 2021
Closed
akosyakov added a commit that referenced this issue Jun 23, 2021
@akosyakov
[code] fix #2812: workspace sharing support
05d2837
@akosyakov akosyakov mentioned this issue Jun 23, 2021
Merged
1 task
JanKoehnlein pushed a commit that referenced this issue Jun 25, 2021
@akosyakov @JanKoehnlein
[code] fix #2812: workspace sharing support
28de9a7
akosyakov added a commit that referenced this issue Jun 26, 2021
@akosyakov
[code] fix #2812: workspace sharing support
feddeef
akosyakov added a commit that referenced this issue Jun 27, 2021
@akosyakov
[code] fix #2812: workspace sharing support
c41d849
akosyakov added a commit that referenced this issue Jun 28, 2021
@akosyakov
[code] fix #2812: workspace sharing support
39ad790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
editor: code (browser) roadmap item: gitpod code https://bit.ly/3oqjuOn type: feature request New feature or request
Projects
None yet
Milestone
[backlog] June 2021
3 participants
@svenefftinge @akosyakov @csweichel