Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports need descriptions #3059

Closed
markfirmware opened this issue Jan 30, 2021 · 28 comments · Fixed by #7012
Closed

Ports need descriptions #3059

markfirmware opened this issue Jan 30, 2021 · 28 comments · Fixed by #7012

Comments

@markfirmware
Copy link

Quoted from a discussion at https://community.gitpod.io/t/ports-need-a-description/2622

.gitpod.yml

ports:

port: 5080
description: ultibo http server in qemu
onOpen: open-browser
port: 5900
description: normal vnc service to desktop - not used
onOpen: ignore
port: 6080
description: browser novnc service to desktop
onOpen: open-browser

The description should then appear next to the port number (or be in a hover tip or something) anywhere a port number is displayed.

There might be a cli tool or text database on the internet to help with names of well-known or commonly used port numbers.

Yes, this is a request not for a feature but for an improvement of the Open Ports tab (and anywhere else ports are listed. )

That tab lists each port number and preview/browser/private options. Without a description for the port, one can only guess as to its purpose.

Regards,
Mark

@csweichel
Copy link
Contributor

@svenefftinge It'd be great to have your input here how/when this fits on the product roadmap.

@csweichel csweichel removed this from the [backlog] March 2021 milestone Mar 1, 2021
@akosyakov
Copy link
Member

akosyakov commented Mar 2, 2021

btw we could display which command is running behind the port in the ports view?

@davidwindell
Copy link
Contributor

We'd really like this feature too, when you have ~5+ running services, spotting port "8080" or whichever is exposed gets quite cumbersome in the list.

Looking at the gitpod.yml spec you marked the "name" property as deprecated, I couldn't see any reason why though?

@sgurlt
Copy link

sgurlt commented May 25, 2021

+1 that would be great to have :-)

@stale
Copy link

stale bot commented Aug 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 23, 2021
@markfirmware
Copy link
Author

.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Aug 23, 2021
@svenefftinge
Copy link
Member

Having an explicit description that is shown in the view in VS Code would be great. Ideally, we also show the program that is serving the port. @csweichel I kind of remember you mentioned this was relatively easy.
I think we should allow for a description in the configuration and if that is not set we show the program name.

@akosyakov
Copy link
Member

I think we could look at cmd of the pid behind the port, similarly how VS Code does it. If we cannot use eBPF.

@csweichel
Copy link
Contributor

We have some provisioning for using seccomp-notify for extracting the command that opened the port. It's predominantly a supervisor and workspacekit change.

@csweichel
Copy link
Contributor

/team IDE

@roboquat
Copy link
Contributor

@csweichel: The label(s) team: ide cannot be applied. These labels are supported: team: IDE, team: meta, team: workspace

In response to this:

/team IDE

Instructions for interacting with me are available here. If you have questions or suggestions related to my behavior, please file an issue against the gitbot repository.

@csweichel
Copy link
Contributor

unfortunately the IDE team is currently underwater with the local companion app. Please re-schedule in two weeks time.

@akosyakov
Copy link
Member

/schedule

@roboquat
Copy link
Contributor

@akosyakov: Issue scheduled in the IDE team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akosyakov
Copy link
Member

akosyakov commented Sep 29, 2021

Unfortunately after team discussions we realised that we don't have capacity for new features and have to focus more on bug fixes and robust deployments. I removed it from the scheduled for now.

@akosyakov
Copy link
Member

Descriptions can be super long how we would display them in the remote explorer? It is already quite crowded there. Would be tooltip enough?

cc @davemecha since you had some ideas.

@davidwindell
Copy link
Contributor

As an end-user, the biggest advantage by far of this would be to make it easy for newcomers to our projects to know exactly which of the ports they should use to view the primary application/web server.

In most of ours, we have ~6 ports shown but only one of them (8080) is actually used by developers working on the project.

Either the ability to highlight a port (i.e. "Launch Application") or to label with short names such as "HTTP" would be ideal.

@davemecha
Copy link

davemecha commented Dec 2, 2021

Descriptions can be super long how we would display them in the remote explorer? It is already quite crowded there. Would be tooltip enough?

cc @davemecha since you had some ideas.

I would prefer a name over a description. The use case is similar to the terminals and the visualization could be as well:

image

image

A tooltip would be better than nothing, but I don't think it's that helpful. I work often with multiple ports in projects. If one doesn't want to use the port names, he just can omit the field in the .gitpod.yml. So no visual overhead for those users.
Also a tooltip might conflict with the actions on hover.

@akosyakov
Copy link
Member

We could have both, short name as a prefix and description as a tooltip?

@davemecha
Copy link

We could have both, short name as a prefix and description as a tooltip?

Sure, as far as the tooltip is only displayed when a description field is provided in gitpod.yml this might be an option.

Gitpod could track the usage of those features when parsing the yml files and maybe improve further depending on usage data. :)

@Foxhoundn
Copy link

Please, this would have been great + let me copy the whole URL from the ports view! :)

Also if there could be some indication of why / what opened other ports, that would be useful -

CleanShot 2021-12-16 at 13 24 01

@akosyakov
Copy link
Member

akosyakov commented Dec 17, 2021

As first step we will allow to specify name prefix and tooltip description in .gitpod.yml

We could also auto derive prefix by probing ports for well known application protocols, and detect cmd which exposed the port as a description. But I think we need 2 new issues for that. cc @loujaybee

@akosyakov
Copy link
Member

Please, this would have been great + let me copy the whole URL from the ports view! :)

Do you know about gp url? Please file a new issue to add copy port URL command to VS Code.

@Foxhoundn
Copy link

Please, this would have been great + let me copy the whole URL from the ports view! :)

Do you know about gp url? Please file a new issue to add copy port URL command to VS Code.

If I wanted to contribute myself, can I? Where is the repo that handles that?

@akosyakov
Copy link
Member

If I wanted to contribute myself, can I? Where is the repo that handles that?

It is here: https://github.com/gitpod-io/openvscode-server/tree/gp-code/main

@davidwindell
Copy link
Contributor

Did anyone every get this to work? We've had descriptions in our yml's since this was merged but dont' see anything in the IDE

@davidwindell
Copy link
Contributor

Ah, I've just found #9797 which explains it

@davemecha
Copy link

@davidwindell yeah, I also can't wait for this feature to finally work- That would be so helpful...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants