Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prebuilds] Remove prebuild labels #3303

Closed
csweichel opened this issue Mar 1, 2021 · 1 comment
Closed

[prebuilds] Remove prebuild labels #3303

csweichel opened this issue Mar 1, 2021 · 1 comment
Labels
type: deprecate/remove feature We're about to remove a feature. If you want to object, now is the time :)

Comments

@csweichel
Copy link
Contributor

When we first introduced prebuilds we added functionality so that the bot could add comments instead of setting the commit status. This feature doesn't make much sense and is broken (see #3235). We should remove it.

@csweichel csweichel added the type: deprecate/remove feature We're about to remove a feature. If you want to object, now is the time :) label Mar 1, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 23, 2021

The addComment feature is now fixed, and several users have expressed interest in continuing to use it.

Also, a PR comment is a nice, obvious way to encourage contributors and reviewers to use Gitpod, while a PR "Check" is very discreet and much easier to ignore or overlook (especially when all "Checks" are green and thus collapsed / hidden from view). Additionally, other popular tools/services also have a comment feature available (e.g. Netlify, Vercel, etc).

I would vote for:

  • addCheck: keep ✅
  • addComment: keep ✅
  • addBadge: keep ✅
  • addLabel: deprecate and remove ❌ (it's still broken and nobody has complained about it, as opposed to comments, so this is probably the least useful feature here)

@jankeromnes jankeromnes changed the title [prebuilds] Remove prebuild comments [prebuilds] Remove prebuild labels Jul 7, 2021
AlexTugarev added a commit that referenced this issue Jul 7, 2021
AlexTugarev added a commit that referenced this issue Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: deprecate/remove feature We're about to remove a feature. If you want to object, now is the time :)
Projects
None yet
Development

No branches or pull requests

2 participants