Skip to content

gitpod.io check doesn't run even though github app is installed and .gitpod.yml configured #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rfay opened this issue Apr 6, 2021 · 6 comments
Labels
type: bug Something isn't working

Comments

@rfay
Copy link

rfay commented Apr 6, 2021

Bug description

I installed the gitpod.io app some time ago on ddev and set up .gitpod.yml, etc. It worked at some point - the checks showed gitpod there. But then I started noticing it not showing up in checks any more.

Today I am reviewing docs for upcoming ddev v1.17.0 release and wanted to make sure they reflected the truth in saying you could go find the gitpod check... and I couldn't get it to work at all.

I completely uninstalled the github gitpod.io app and reinstalled it (today).

Steps to reproduce

To see it, visit any ddev PR, see for example ddev/ddev#2929 - there is no gitpod.io check.

Here are the permissions

(Note that I can't drag an image into your cool-looking bug report form on creation)

But here it is on edit:

Installed_GitHub_App_-_gitpod_io

Here is the .gitpod.yml: https://github.com/drud/ddev/blob/master/.gitpod.yml

Expected behavior

I expect to see a check show up for gitpod.

Example repository

This is currently happening on https://github.com/drud/ddev

@JanKoehnlein
Copy link
Contributor

It seems like our GitHub app no longer creates buttons on PRs. See #3812

I've also proposed some fixes to re-enable your dockerfile.

@rfay
Copy link
Author

rfay commented Apr 7, 2021

Thanks @JanKoehnlein - I was talking here about the check, not about a button on PR.

tune-up_for_prebuild-init-command_by_shaal_·_Pull_Request__22_·_shaal_ddev-gitpod

@JanKoehnlein
Copy link
Contributor

I think the check doesn't appear because you don't have a prebuild/init task in your .gitpod.yml. Other tasks are only executed in interactive workspaces.

@rfay
Copy link
Author

rfay commented Apr 7, 2021

Ah, that would explain it. Even though it has addcheck: true it doesn't happen if it doesn't do something in prebuild. Will try that.

@rfay
Copy link
Author

rfay commented Apr 7, 2021

Added an init in ddev/ddev#2933, it didn't add the check there.

Is there a difference between init: and prebuild: ?

@rfay
Copy link
Author

rfay commented Apr 7, 2021

Working, thanks for your wonderful and prompt support.

gitpod__Move_make_into_init_in__gitpod_yml_by_rfay_·_Pull_Request__2933_·_drud_ddev

@rfay rfay closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants