You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Github allows users to Block command line pushes that expose my email but it seems gitpod does not notice that setting and instead uses my primary GitHub email when generating the workspace ~/.gitconfig file.
It seems like there are at least 2 different ways to solve this niche problem:
Change something like manager/create.go to allow GIT_COMMITTER_EMAIL if the user has set it in their "Variables" list
Change something like server/.../github-auth-provider.ts to store the email address that GitHub expects (e.g. 253202+philschatz@users.noreply.github.com) if no public emails are present.
Would either of these approaches (or some other ones) work? If so, it's probably just a couple of lines to fix but I'm happy to try making the changes!
The text was updated successfully, but these errors were encountered:
The comprehensive approach would be to add an optional commitEmail next to the primaryEmail, so that it would be filled in for both GitHub and GitLab users.
Hello!
Github allows users to Block command line pushes that expose my email but it seems gitpod does not notice that setting and instead uses my primary GitHub email when generating the workspace
~/.gitconfig
file.It seems like there are at least 2 different ways to solve this niche problem:
GIT_COMMITTER_EMAIL
if the user has set it in their "Variables" list253202+philschatz@users.noreply.github.com
) if no public emails are present.Would either of these approaches (or some other ones) work? If so, it's probably just a couple of lines to fix but I'm happy to try making the changes!
The text was updated successfully, but these errors were encountered: