Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom email addresses #4101

Closed
philschatz opened this issue Apr 28, 2021 · 3 comments
Closed

Support custom email addresses #4101

philschatz opened this issue Apr 28, 2021 · 3 comments
Assignees

Comments

@philschatz
Copy link
Contributor

Hello!

Github allows users to Block command line pushes that expose my email but it seems gitpod does not notice that setting and instead uses my primary GitHub email when generating the workspace ~/.gitconfig file.

image

It seems like there are at least 2 different ways to solve this niche problem:

  1. Change something like manager/create.go to allow GIT_COMMITTER_EMAIL if the user has set it in their "Variables" list
  2. Change something like server/.../github-auth-provider.ts to store the email address that GitHub expects (e.g. 253202+philschatz@users.noreply.github.com) if no public emails are present.

Would either of these approaches (or some other ones) work? If so, it's probably just a couple of lines to fix but I'm happy to try making the changes!

@AlexTugarev
Copy link
Member

Hey @philschatz,
This is a duplicate of #387.

The comprehensive approach would be to add an optional commitEmail next to the primaryEmail, so that it would be filled in for both GitHub and GitLab users.

@philschatz
Copy link
Contributor Author

@AlexTugarev , Thanks for that feedback. I created a Pull Request (#4115) which I believe uses the comprehensive approach you mentioned.

@corneliusludmann
Copy link
Contributor

Fixed with #4115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants