Skip to content

Keep the more actions button (three dots) always visible #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jun 1, 2021 · 0 comments · Fixed by #4454
Closed

Keep the more actions button (three dots) always visible #4363

gtsiolis opened this issue Jun 1, 2021 · 0 comments · Fixed by #4454

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 1, 2021

Problem to solve

The more actions button (three dots) can be hard a) to discover as a user and b) to describe in the documentation as
a user interaction. See relevant discussion (internal). /cc @JanKoehnlein

This affects the following pages which contain list entries with a disappearring more actions button:

  1. Workspaces
  2. Variables
  3. Integrations
  4. Teams

Alternatively, surfacing more action on hover could limit or remove the need to use the more actions button, see #4213.

Risk

It'd be worth checking if the interaction can cause any confusion due to this issue (see #3731).

Proposal

Let's keep the more actions button (three dots) always visible on all list items.

BEFORE AFTER
image image

The fix should be relatively simple by repeating the following on every instance:

diff --git a/components/dashboard/src/settings/Integrations.tsx b/components/dashboard/src/settings/Integrations.tsx
index f4fe2be3..8a5bea48 100644
--- a/components/dashboard/src/settings/Integrations.tsx
+++ b/components/dashboard/src/settings/Integrations.tsx
@@ -283,7 +283,7 @@ function GitProviders() {
         <h2>Manage permissions for git providers.</h2>
         <div className="flex flex-col pt-6 space-y-2">
             {authProviders && authProviders.map(ap => (
-                <div key={"ap-" + ap.authProviderId} className="flex-grow flex flex-row hover:bg-gray-100 dark:hover:bg-gray-800 rounded-xl h-16 w-full transition ease-in-out group">
+                <div key={"ap-" + ap.authProviderId} className="flex-grow flex flex-row hover:bg-gray-100 dark:hover:bg-gray-800 rounded-xl h-16 w-full transition ease-in-out">
                     <div className="px-4 self-center w-1/12">
                         <div className={"rounded-full w-3 h-3 text-sm align-middle " + (isConnected(ap.authProviderId) ? "bg-green-500" : "bg-gray-400")}>
                             &nbsp;
@@ -417,7 +417,7 @@ function GitIntegrations() {
                     <div className="p-0 my-auto flex flex-col w-7/12">
                         <span className="my-auto truncate text-gray-500 overflow-ellipsis">{ap.host}</span>
                     </div>
-                    <div className="my-auto flex w-1/12 mr-4 opacity-0 group-hover:opacity-100 justify-end">
+                    <div className="my-auto flex w-1/12 mr-4 justify-end">
                         <div className="self-center hover:bg-gray-200 dark:dark:bg-gray-800 rounded-md cursor-pointer w-8">
                             <ContextMenu menuEntries={gitProviderMenu(ap)}>
                                 <svg className="w-8 h-8 p-1 text-gray-600 dark:text-gray-300" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><title>Actions</title><g fill="currentColor" transform="rotate(90 12 12)"><circle cx="1" cy="1" r="2" transform="translate(5 11)" /><circle cx="1" cy="1" r="2" transform="translate(11 11)" /><circle cx="1" cy="1" r="2" transform="translate(17 11)" /></g></svg>
@gtsiolis gtsiolis changed the title Keep the more actions button always visible Keep the more actions button (three dots) always visible Jun 1, 2021
@JanKoehnlein JanKoehnlein added this to the [backlog] June 2021 milestone Jun 1, 2021
@corneliusludmann corneliusludmann self-assigned this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants