-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Add ItemsList component #4454
Conversation
/werft run 👍 started the job as gitpod-build-clu-improve-items-list.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, thanks for adding this @corneliusludmann! Works like a charm. 🔮
FWIW, the current teams settings section will probably become obsolete and be removed once we have the new Teams & Projects in place.
<div className="flex-1 flex flex-col overflow-x-auto"> | ||
<Item className="w-full bg-gitpod-kumquat-light py-6 px-6"> | ||
<ItemFieldIcon> | ||
<img src={exclamation} alt="Exclamation Mark" className="m-auto" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks for adding the alt
text here! 🏅
Cross-posting #3508 for visibility and future reference.
<ItemField className="w-4/12">Context</ItemField> | ||
<ItemField className="w-2/12">Pending Changes</ItemField> | ||
<ItemField className="w-2/12">Last Start</ItemField> | ||
<ItemFieldContextMenu /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Love at first sight! ❤️
OK, good to know. Then, I think it's a good idea to revert the changes in the Teams page for now and merge this afterwards as is. Thanks for your review! 👍 |
1830730
to
57f26d5
Compare
This PR adds an
ItemsList
component that replaces the divs at the following places:This makes these nearly identical HTML structures more maintainable and consistent.
This also fixes #4363 and fixes #3731.
/cc @gtsiolis
TODO: