[dashboard] Fix workspace entry truncation #4416
Conversation
|
/werft run 👍 started the job as gitpod-build-clu-fix-workspace-entry-truncate.4 |
|
/werft run 👍 started the job as gitpod-build-clu-fix-workspace-entry-truncate.5 |
| <div className="flex flex-col"> | ||
| <div className="text-gray-500 overflow-ellipsis truncate">{ws.description}</div> | ||
| <div className="flex flex-col w-4/12"> | ||
| <Tooltip content={ws.description}> |
There was a problem hiding this comment.
issue: Adding the tooltip on all element can a) make the interface feel slightly overwelmed, b) feel redandunt on some elements like the workspace name, and introduce some visual imbalance (see screenshots).
| Context | Changes |
|---|---|
 |
 |
There was a problem hiding this comment.
Yes, absolutely. Since the truncation is fixed in #4454 already, I'll close this one.
There was a problem hiding this comment.
Thanks @corneliusludmann! 🏓
| </div> | ||
| <div className="flex flex-col items-start w-2/12"> | ||
| <div className="text-gray-500 truncate">{currentBranch}</div> | ||
| <Tooltip content={currentBranch} className="w-full"> | ||
| <div className="text-gray-500 overflow-ellipsis truncate w-full">{currentBranch}</div> |
There was a problem hiding this comment.
suggestion: May I suggest to leave the truncation on and remove most, if not all, tooltips for this iteration? What do you think? 🎈
Ideally, we could make the Context column so that it contains more compact information (see #3594). This way, we would only need a tooltip on the first row of the context column.
Additionally, on the Pending Changes column we could truncate the branch name and offer a copy-to-clipboard button without also having a tooltip.
The actual change is the commit 9f41b1d that fixes the truncation in the workspace list:
Besides this, this PR also has the commit 4476666 that adds tooltips for the values. The rationale behind this is that it should be possible to read the whole non-truncated value somehow:
The downside is that the tooltip is always there, no matter if truncated or not. I don't know an easy way to show the tooltip for truncated values only. If we don't like this behavior, we can drop this commit.