Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Horizontal scrollbar in “Changes” dropdown has no effect #4570

Closed
corneliusludmann opened this issue Jun 22, 2021 · 3 comments
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code

Comments

@corneliusludmann
Copy link
Contributor

When a workspace has changes (e.g. untracked or uncommitted files, unpushed commits), the files are truncated. Therefore, the horizontal scrollbar has no effect.

image

There are two options:

  1. Hide the horizontal scrollbar.
  2. Don't truncate the lines and allow to scroll.

I'm personally in favor of (2) because the truncated file paths make some information inaccessible. E.g. here you don't see which files exactly have been changed:

image

/cc @gtsiolis

@corneliusludmann corneliusludmann added component: dashboard type: improvement Improves an existing feature or existing code labels Jun 22, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 22, 2021

I'm personally in favor of (2) because the truncated file paths make some information inaccessible. E.g. here you don't see which files exactly have been changed:

Side note: I'm occasionally bitten by the same thing (truncated text not helpful because the relevant part is hidden). So I've recently taken to adding a title attribute to all truncated texts I see.

For pending changes for example, you'll notice that hovering over each truncated entry reveals the full path. See also the new title attribute in (all the way right):

const entry = <div className={`px-4 flex py-3 ${clickable ? 'hover:bg-gray-200 dark:hover:bg-gray-800' : ''} text-sm leading-1 ${e.customFontStyle || font} ${e.separator ? ' border-b border-gray-200 dark:border-gray-800' : ''}`} title={e.title}>

@corneliusludmann
Copy link
Contributor Author

Thanks for the addition, @jankeromnes! Generally speaking, I see it the same way. However, when you don't know if the value is truncated or not, the tooltip could be redundant. See discussion in this PR: #4416. But still tend to be more in favor of it.

@stale
Copy link

stale bot commented Sep 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 20, 2021
@stale stale bot closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

2 participants