-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code] serve each webview from own origin #4529
Comments
akosyakov
added a commit
that referenced
this issue
Jul 8, 2021
decoupled from workpace origin (also extension host origin)
akosyakov
added a commit
that referenced
this issue
Jul 8, 2021
decoupled from workpace origin (also extension host origin)
akosyakov
added a commit
that referenced
this issue
Jul 13, 2021
decoupled from workpace origin (also extension host origin)
akosyakov
added a commit
that referenced
this issue
Jul 14, 2021
decoupled from workpace origin (also extension host origin)
akosyakov
added a commit
that referenced
this issue
Jul 15, 2021
decoupled from workpace origin (also extension host origin)
akosyakov
added a commit
that referenced
this issue
Jul 16, 2021
decoupled from workpace origin (also extension host origin)
akosyakov
added a commit
that referenced
this issue
Jul 16, 2021
decoupled from workpace origin (also extension host origin)
csweichel
added
groundwork: awaiting deployment
and removed
groundwork: in review
labels
Jul 16, 2021
MatthewFagan
pushed a commit
to trilogy-group/gitpod
that referenced
this issue
Dec 15, 2021
decoupled from workpace origin (also extension host origin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we serve all webviews from the same origin which:
Before we tried to serve webview from own origin by producing subdomains like
{webview-uuid}-webview-{workspace-id}
, but such attempts were unsuccessful since DNS label is limited to 67 chars.Instead we can try to produce URLs like
webview-{webview-uuid}.eu-09.gitpod.io/{workspace-id}
. It will give each webview an unique origin and allow ws-proxy to redirect requests to a proper workspace to load common webview bootstrap code.After it is done we should revert in VS Code Web: https://github.com/gitpod-io/vscode/blob/eae95e2b37ad034edbe411d783b2980f20ed0688/src/vs/workbench/contrib/webview/browser/pre/main.js#L26-L28
Important: we cannot deprecate old webview route till Theia is removed and all workspaces using VS Code relying on it are stopped.
The text was updated successfully, but these errors were encountered: