Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] text wrapping on "workspace is already running" dialog #4556

Closed
ghuntley opened this issue Jun 21, 2021 · 9 comments · Fixed by #5248
Closed

[dashboard] text wrapping on "workspace is already running" dialog #4556

ghuntley opened this issue Jun 21, 2021 · 9 comments · Fixed by #5248
Labels
component: dashboard type: bug Something isn't working

Comments

@ghuntley
Copy link
Contributor

Bug description

2021-06-21_11-58-56

Steps to reproduce

  1. Start workspace via https://gitpod.io/#EXAMPLE_DIR=typescript%2Fgraphql/https://github.com/ghuntley/prisma-examples/tree/gh/gitpodify
  2. Start another workspace via https://gitpod.io/#EXAMPLE_DIR=typescript%2Fgraphql/https://github.com/ghuntley/prisma-examples/tree/gh/gitpodify

Expected behavior

Design implementation accommodates long URLs

2021-06-21_11-58-56

Example repository

No response

Anything else?

No response

@jankeromnes
Copy link
Contributor

Good catch! This qualifies as a good-first-issue that anyone can pick up (please add a comment below if you'd like to try fixing this).

The corresponding React element needs:

  • A truncate CSS classname (see corresponding Tailwind docs)
  • A title attribute (so that you can still see the full text when hovering over the truncated text)

Code location:

<p>{w.workspace.contextURL}</p>

@sandyabhi
Copy link

sandyabhi commented Jun 22, 2021

Hey, @ghuntley I would like to work on this.

@gtsiolis
Copy link
Contributor

Hi @sandyabhi! Sounds great, feel free to open PR with a fix and and link back to this issue. 🏓

@ghuntley
Copy link
Contributor Author

Awesome. Make it so @sandyabhi

@sandyabhi
Copy link

Hi, @ghuntley is there any gitpod IRC channel? I have been stuck after the "serve -s build" localhost 5000 showing error.

@ghuntley
Copy link
Contributor Author

ghuntley commented Jun 22, 2021 via email

@sandyabhi
Copy link

sandyabhi commented Jun 25, 2021

hi, @ghuntley @gtsiolis
I just open forked gitpod repo
after all the installation gitpod do
I type the command "npm serve build "
then " serve -s build"
localhost: 5000 shows
Screenshot (14)

I haven't been able to figure out the error.

@gtsiolis
Copy link
Contributor

/assign @Cahllagerfeld

@roboquat
Copy link
Contributor

@gtsiolis: GitHub didn't allow me to assign the following users: Cahllagerfeld.

Note that only gitpod-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Cahllagerfeld

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants