Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out Teams & Projects top menu navigation #4622

Closed
jankeromnes opened this issue Jun 25, 2021 · 3 comments · Fixed by #5077
Closed

Figure out Teams & Projects top menu navigation #4622

jankeromnes opened this issue Jun 25, 2021 · 3 comments · Fixed by #5077

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 25, 2021

From #4571 (review):

One last question: Somewhere we split the team dropdown into two distinct elements. Could we restore this as one component? See relevant discussion (internal). ❓

We've recently split the Team selector dropdown into two parts:

  1. Clicking on the team name goes to the default team page (i.e. "Projects", or "Workspaces" if your personal account is selected)
  2. Clicking on the arrow allows switching to a different team

Screenshot 2021-06-25 at 18 12 56

The thought was to allow a sort of "breadcrumb navigation", allowing to:

  1. Dive into Teams > Projects > (a project) > (a prebuild)
  2. Go back (e.g. to the Team, or switch to another team)

similar to how Vercel does it:

Screen Shot 2021-06-25 at 14 42 01

However, the current implementation feels awkward:

  1. Clicking on my name (biggest clickable surface) does the same thing as clicking on the Gitpod logo (i.e. go to "Workspaces") -- it feels awkward that these two "primary" items go to the same place (i.e. broken link?)
  2. Switching teams can only be done by clicking on the super small down-arrow (requires more precision & effort and might get overlooked)

It would be cool to improve this.

Proposal

In this iteration we can:

  1. Introduce a new team selector (dropdown) component
  2. Use a similar icon for showing the second-level page like prebuilds
  3. (Optional) Add a hypelink on the project breadcrumb item to link back to project overview page.

Designs

Default Hover Active
Default Hover Active
Project Prebuild
Project Prebuild

See design specs.

@jankeromnes
Copy link
Contributor Author

Giving this a go 🖌️

@AlexTugarev
Copy link
Member

@jankeromnes please base on #4876 🙏🏻 as I already added some changes to the menu structure.

@jankeromnes
Copy link
Contributor Author

@AlexTugarev makes sense, thanks! I agree 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants