[server] `testEmptyProject` of the GitLab context parser fails

[corneliusludmann]

The testEmptyProject of the GitLab context parser fails:

gitpod/components/server/src/gitlab/gitlab-context-parser.spec.ts

Lines 531 to 548 in bc6c9f7

	@test public async testEmptyProject() {
	const result = await this.parser.handle({}, this.user, 'https://gitlab.com/gp-test-group/gp-test-empty-project');
	expect(result).to.deep.include({
	"ref": undefined,
	"refType": undefined,
	"revision": undefined,
	"isFile": false,
	"repository": {
	"host": "gitlab.com",
	"owner": "gp-test-group",
	"name": "gp-test-empty-project",
	"cloneUrl": "https://gitlab.com/gp-test-group/gp-test-empty-project.git",
	"private": false,
	"defaultBranch": null
	},
	"title": "gp-test-group/gp-test-empty-project"
	})
	}

1) TestGitlabContextParser
       testEmptyProject:
     AssertionError: expected { Object (isFile, path, ...) } to have deep property 'ref'
      at TestGitlabContextParser.<anonymous> (src/gitlab/gitlab-context-parser.spec.ts:549:36)
      at Generator.next (<anonymous>)
      at fulfilled (src/gitlab/gitlab-context-parser.spec.ts:19:58)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

The actual result is:

{
  "isFile": false,
  "path": "",
  "title": "gp-test-group/gp-test-empty-project - main",
  "revision": "",
  "repository": {
    "host": "gitlab.com",
    "name": "gp-test-empty-project",
    "owner": "gp-test-group",
    "cloneUrl": "https://gitlab.com/gp-test-group/gp-test-empty-project.git",
    "defaultBranch": "main",
    "private": false
  }
}

Opening the empty workspace actually works, though. It's just the test that fails and needs to be fixed.

[AlexTugarev]

@corneliusludmann, from reading the expectation and the error message, to me it seems like the test could be adjusted. with no bike-shedding in mind, { ref: undefined, [more] } is not a typical response, but { [more] }.

perhaps there was a change in the GitLab library we use and this response is fixed now.

Opening the empty workspace actually works, though. It's just the test that fails and needs to be fixed.

👍🏻

[csweichel]

/schedule

[corneliusludmann]

/assign corneliusludmann

[roboquat]

@corneliusludmann: GitHub didn't allow me to assign the following users: me.

Note that only gitpod-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[corneliusludmann]

/assign corneliusludmann