Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Too large backups are not deleted from the tmpdir #4939

Closed
csweichel opened this issue Jul 25, 2021 · 1 comment · Fixed by #4941
Closed

[ws-daemon] Too large backups are not deleted from the tmpdir #4939

csweichel opened this issue Jul 25, 2021 · 1 comment · Fixed by #4941
Labels
component: ws-daemon groundwork: awaiting deployment operations: past incident This issue arose during a past incident or its post-mortem type: bug Something isn't working

Comments

@csweichel
Copy link
Contributor

Bug description

When ws-daemon produces a backup and that backup exceeds a configurable size, the file is not uploaded to the remote storage. At the same time the file is not removed from the node, potentially adversely affecting the operations of the node.

We should remove such large backups, or better yet, don't produce them in the first place.

Steps to reproduce

Create a workspace that consumes more than the configured disk space limit

Expected behavior

The backup file should not be created, or at least be deleted.

Example repository

No response

Anything else?

No response
@csweichel csweichel added component: ws-daemon type: bug Something isn't working labels Jul 25, 2021
@csweichel csweichel added the operations: past incident This issue arose during a past incident or its post-mortem label Jul 25, 2021
@csweichel
Copy link
Contributor Author

/schedule

@csweichel csweichel mentioned this issue Jul 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ws-daemon groundwork: awaiting deployment operations: past incident This issue arose during a past incident or its post-mortem type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ws-daemon] Always remove temp backup file gitpod-io/gitpod
2 participants
@csweichel @roboquat