Terminal Font Issue Has Returned with v1.58.2

[lechien73]

Bug description

The terminal font issues that were fixed in #4130 have returned in the new version of VS Code.

Again, the terminal font is distorted; however, this time, cycling the font in Settings doesn't make a difference.

Steps to reproduce

Open a workspace (I use Brave browser). Observe the terminal font and try to change it in Settings.

Expected behavior

A normal terminal.

Example repository

No response

Anything else?

I cleared the cache in my browser and hard refreshed. Colleagues have confirmed they experience the same behaviour.

[kevin-ci]

Same issue here. Same reproduction steps. Also using Brave - 1.26.67 Chromium: 91.0.4472.114 (Official Build) (64-bit)

[Sarosim]

Same here, Brave Version 1.27.108 Chromium: 92.0.4515.107 (Official Build) (64-bit)

[heldr]

A workaround I found is using nativefier to build your own Electron workspace. Somehow it doesn't happen on Electron 🤷‍♂️

nativefier <GITPOD_WORKSPACE_URL> -n <YOUR_APP_NAME> --fast-quit --internal-urls gitpod.io

[ghuntley]

Confirming this happened to me moments ago on https://peach-rabbit-vh29qfah.ws-us13.gitpod.io/

about://

92.0.4515.107 (Official Build) (arm64)
--
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | macOS Version 11.5.1 (Build 20G80)
JavaScript | V8 9.2.230.20
User agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36


<br class="Apple-interchange-newline">

Reloading the page resolved the matter.

[0xjjpa]

Confirming the same bug here, just started a new workspace now.

[TheBotlyNoob]

Same thing for me

[lechien73]

My current workaround has been to edit settings.json and add the following new settings:

{
    "terminal.integrated.lineHeight": 1.2,
    "terminal.integrated.letterSpacing": 2
}

[hrithikwins]

I still have the same problem with this latest August Update

[ghuntley]

Same problem with GitHub Codespaces as well so confirming upstream vscode issue.

…

On Sat, 21 Aug 2021, 4:08 pm Hrithik Tiwari, ***@***.***> wrote: I still have the same problem with this latest August Update [image: image] <https://user-images.githubusercontent.com/42163313/130312395-469912be-b170-4199-94d8-0e70aad3abb2.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5014 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7C6NQON6DX6CSQSOA36LT547FLANCNFSM5BGXXDGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[akosyakov]

We removed it from the current groundwork, since it should be fixed in the upstream first.

[neuronick]

My current solution, which fixes the font problem for me on MacOS Mojave + Chrome:
"terminal.integrated.gpuAcceleration": "canvas"

This works event better than lineHeight / letterSpacing proposed earlier.

Without this setting:

With this setting:

[ar065]

Brave's adblocker did it for me. Disabling it fixed the issue

[hrithikwins]

@wolfy01 can you tell how to do it, I tried disabling the adblocker but it doesn't work, also check this https://community.brave.com/t/i-keep-getting-reports-due-to-canvas-fingerprint-prevention/288876

[Bulletninja]

@hrithikrtiwari I just clicked the brave icon and disabled it.

[hrithikwins]

Ohh great, I tried it on youtube and it works
Thanks @Bulletninja

[ilovejs]

{
"editor.fontSize": 14,
"editor.fontFamily": "Courier",
"redhat.telemetry.enabled": false,
"terminal.integrated.fontFamily": "Courier",
"terminal.integrated.lineHeight": 1.2,
"terminal.integrated.letterSpacing": 0,
"terminal.integrated.gpuAcceleration": "canvas",
"workbench.preferredDarkColorTheme": "Visual Studio Dark",
"window.autoDetectColorScheme": true,
"workbench.colorTheme": "Default Dark+"
}

[scottyeager]

Disabling Brave's adblocker also resolved this issue for me.

[oktayacikalin]

Disabling Brave's adblocker also resolved this issue for me.

Same here in elementary OS 6.1.

[loujaybee]

Moving to scheduled to investigate. 🙏

[mustard-mh]

Close see wiki xtermjsFAQ/characters-are-getting-cut-off-in-the-terminal

[uriva]

@mustard-mh reproduction: install brave on ubuntu and open this repo in gitpod: https://github.com/hyroai/gamla

[mustard-mh]

@uriva we should go to and disable fingerprinting brave://settings/shields.

Some browsers (eg. Brave) have privacy features that prevent some fingerprinting techniques that use the canvas such as checking what fonts are installed or determining how certain fonts are actual rasterized. source

[uriva]

just saying it's reproducible, so maybe you mean to close because it's a problem with a dependency rather than gitpod itself?

[mustard-mh]

Yes, sorry for misleading @uriva, we can't do anything according to this wiki

[imorri]

Had the same issue with Brave on Mac and Solus, Firefox and Safari no issue.
I found disabling fingerprint tracking in Brave settings resolved the issue.