Skip to content

Fix rounded corner / background gap in ContextMenu #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jankeromnes opened this issue Aug 6, 2021 · 4 comments
Open

Fix rounded corner / background gap in ContextMenu #5086

jankeromnes opened this issue Aug 6, 2021 · 4 comments
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 6, 2021

Bug description

There is a breeze coming through this gap, and it should be fixed, ideally before the winter. 🌬️ 🥶

From #5077 (comment) :

issue: This is minor but there's a small gap on the corners due to corner radiuses. It should be barely noticable but if there's an easy fix let's also include it here. Otherwise, a follow up issue could suffice. 🏓

A B
Screenshot 2021-08-06 at 10 46 57 AM Screenshot 2021-08-06 at 10 46 43 AM

Steps to reproduce

  1. Click on any DropDown / ContextMenu in the dashboard
  2. Zoom in
  3. Feelsbadman

Expected behavior

  1. Feelsgoodman

Example repository

https://github.com/gitpod-io/gitpod

Anything else?

Do you have any fries? 🍟

@jankeromnes
Copy link
Contributor Author

@gtsiolis About the good-first-issue label: I considered adding it, but then I wasn't sure, because I myself don't know how to fix this problem (I tried a few things, like not rounding the background's corners but using overflow: hidden instead, but that didn't work).

In general for good-first-issues, I like at least being able to point interested contributors in the right direction for a fix, but here I don't really know. 😬

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 6, 2021

@jankeromnes fair point! No strong feelings either way. Removing the good-first-issue label. 🏀

@stale
Copy link

stale bot commented Nov 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 22, 2021
@stale stale bot closed this as completed Dec 2, 2021
@stale stale bot moved this to Done in 🍎 WebApp Team Dec 2, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 2, 2021

Reopening this as it's still relevant.

@gtsiolis gtsiolis reopened this Dec 2, 2021
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Dec 2, 2021
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Dec 2, 2021
@gtsiolis gtsiolis added the team: webapp Issue belongs to the WebApp team label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: No status
Status: Low hanging fruits 🍒
Development

No branches or pull requests

2 participants