Skip to content

Allow users to add projects in teams from self hosted GitLab providers #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Aug 9, 2021 · 8 comments · Fixed by #7125
Closed

Allow users to add projects in teams from self hosted GitLab providers #5115

gtsiolis opened this issue Aug 9, 2021 · 8 comments · Fixed by #7125
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. git provider: gitlab groundwork: in progress team: webapp Issue belongs to the WebApp team type: feature request New feature or request

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 9, 2021

Problem to solve

The upcoming Teams & Projects feature supports adding repositories from GL (gitlab.com) and GH (github.com) but does not support projects from self hosted GitLab instances.

See also relevant discussion in #5113 (comment). Cc @AlexTugarev

Risks

This would require first to introduce any safety mechanisms that make the dashboard usable even if the self hosted instances go offline. Such mechanisms could include caching information (see #5038) or using skeleton loaders to handle any slow connection issues (see #5075).

@AlexTugarev
Copy link
Member

@gtsiolis, I suggest to limit the scope of this issue to self-managed GitLabs. We assume that it will work with little changes, just by relaxing the blocker.

With GHE things look much different. The configuration part of GItHub Prebuilds requires to generate a key and import it into Gitpod, which is currently supported at deploy-time only.

@gtsiolis gtsiolis changed the title Allow users to add projects in teams from self hosted GitLab and GitHub providers Allow users to add projects in teams from self hosted GitLab providers Aug 20, 2021
@gtsiolis
Copy link
Contributor Author

Sounds absolutely reasonable, @AlexTugarev! I've only added this to avoid missing both points. Renamed this issue for GitLab self hosted and opened #5297 for supporting GitHub self hosted which I'd think also has a lower priority than this one. 🔅

@gtsiolis gtsiolis added the feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. label Aug 20, 2021
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 8, 2021

This was recently brought up in our discord server, see relevant discussion. Cc @jldec

@gtsiolis gtsiolis added the team: webapp Issue belongs to the WebApp team label Nov 8, 2021
@jldec
Copy link
Contributor

jldec commented Nov 12, 2021

#5095 (comment)

@JanKoehnlein
Copy link
Contributor

/schedule

@roboquat
Copy link
Contributor

@JanKoehnlein: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexTugarev
Copy link
Member

/assign

@AlexTugarev
Copy link
Member

This would require first to introduce any safety mechanisms that make the dashboard usable even if the self hosted instances go offline.

@gtsiolis, just from re-reading the issue, I don't think tackling these risks is in scope of the PR to initially support self-managed GitLab instances. preserving details from remote services is a general improvement not directly depending on the provider.

Repository owner moved this from In Groundwork to Done in 🍎 WebApp Team Dec 9, 2021
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. git provider: gitlab groundwork: in progress team: webapp Issue belongs to the WebApp team type: feature request New feature or request
Projects
Archived in project
Status: Next iteration 🛹
Development

Successfully merging a pull request may close this issue.

5 participants