Skip to content

Group avatars fail to load for GitLab groups #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Aug 23, 2021 · 15 comments · Fixed by #8824
Closed

Group avatars fail to load for GitLab groups #5330

gtsiolis opened this issue Aug 23, 2021 · 15 comments · Fixed by #8824
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. groundwork: scheduled team: webapp Issue belongs to the WebApp team user experience

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Following up from #5120 (comment), group avatars fail to load for GitLab groups. 🦊

Missing avatars on groups (a) Missing avatars on personal accounts (b)
Screenshot 2021-08-17 at 5 44 31 PM Frame 34
@gtsiolis gtsiolis added user experience feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Aug 23, 2021
@gtsiolis gtsiolis added the team: webapp Issue belongs to the WebApp team label Sep 20, 2021
@svenefftinge
Copy link
Member

/schedule

@roboquat
Copy link
Contributor

@svenefftinge: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JanKoehnlein
Copy link
Contributor

Let's do this after the launch

@laushinka
Copy link
Contributor

laushinka commented Oct 1, 2021

Is this still happening? I tried with my personal account and I can see my avatar. I'm not sure how to add my group, though. I created one on GitLab but couldn't find it in the New Project dropdown.
Screenshot 2021-10-01 at 11 41 06
:

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Oct 1, 2021

@laushinka Yes, this is still happening but only affects group avatars as described in the issue! You can add more groups at GitLab.com first in order to see these here, see relevant docs.

@laushinka
Copy link
Contributor

@laushinka Yes, this is still happening but only affects group avatars as described in the issue! You can add more groups at GitLab.com first in order to see these here, see relevant docs.

@gtsiolis Turns out I needed to create a project first on GitLab under the group, in order for it to show up in the New Project page. It didn't show up with only a group for me.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Oct 1, 2021

Turns out I needed to create a project first on GitLab under the group, in order for it to show up in the New Project page. It didn't show up with only a group for me.

Ah, yes! That's expected as it does not make much sense to list it there when there are no projects inside, right? What do you think?

@jldec
Copy link
Contributor

jldec commented Dec 21, 2021

/schedule

@roboquat
Copy link
Contributor

@jldec: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldec
Copy link
Contributor

jldec commented Dec 21, 2021

/assign @laushinka

@jldec jldec moved this to In Progress in 🍎 WebApp Team Dec 31, 2021
@laushinka
Copy link
Contributor

Sorry was assigned this since before the holiday. Going to pick something else for now.

/unassign

@gtsiolis
Copy link
Contributor Author

@laushinka shall we also change the issue status on the groundwork board for visibility?

@jldec shall we 🅰️ keep as scheduled until someone picks this up again or 🅱️ remove it altogether from groundwork for now?

@jankeromnes
Copy link
Contributor

Will take a look today 😁

@jankeromnes jankeromnes self-assigned this Mar 15, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Mar 15, 2022

For me, it looks like all the groups that do have avatars (e.g. jankeromnes, gitpod) work as intended, while the groups that don't actually have an avatar (e.g. gitpod-io, gitpod-team) also have no avatar in Gitpod.

Screenshot 2022-03-15 at 13 05 12

Do we have a GitLab group that actually has an avatar, but that doesn't show up in Gitpod? 🤔

EDIT: If you add an avatar to a group, the avatar is still not shown in the list. Will attempt a fix.

@gtsiolis
Copy link
Contributor Author

Re-posting from the discussion with @jankeromnes:

For those that the avatar is visible, it’s because gitpod is a user, not a group. See relevant discussion (internal).

GitLab auto-generates an avatar based on the group name and using a colored background in combination with the first letter of the group name.

However, with or without an uploaded image, avatars fail to load on the Gitpod side.

Repository owner moved this from In Progress to Done in 🍎 WebApp Team Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. groundwork: scheduled team: webapp Issue belongs to the WebApp team user experience
Projects
Archived in project
Status: Next iteration 🛹
8 participants