Skip to content

Improve or remove New Workspace button in the Prebuild page #5523

Closed
@jankeromnes

Description

@jankeromnes

Follow-up to #5474

In the Prebuild page, there is a New Workspace button, with the intent to allow starting workspaces from a Prebuild.

Screen Shot 2021-09-03 at 11 09 34

Currently, the button opens the original context URL of the Prebuild (e.g. a branch, or a Pull Request URL). However, this is no longer the correct link if new commits have been pushed to the original branch.

We could either:

  • Better explain what the New Workspace button does and doesn't
  • Point the New Workspace button more precisely to a specific Prebuild, e.g. by linking to the original full commit URL that this Prebuild was built for
  • Remove the New Workspace button

See also

Suggestion to remove: #5474 (comment)

One question to the New Workspace button on the Prebuild page: is it practical? You cannot start a workspace for old prebuilds anyways, so the page is more of a view. Wdyt of removing it from there?

Suggestion to keep and rename the button: #5474 (comment)

I'd opt to leave it here. I was just using it and didn't have any doubts that it was handy there. It should maybe show what it does (Open workspace on branch branch-name) in the tooltip.

Suggestion to link to a commit context URL: #5474 (comment)

Or, we can still link to the exact (potentially outdated) prebuild by using the commit context URL.

But maybe after using it for a bit we'll know more about what's better here.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions