Skip to content

Improve or remove New Workspace button in the Prebuild page #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Sep 3, 2021 · 2 comments
Closed

Improve or remove New Workspace button in the Prebuild page #5523

jankeromnes opened this issue Sep 3, 2021 · 2 comments
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: stale This issue/PR is stale and will be closed soon roadmap item: teams & projects type: improvement Improves an existing feature or existing code user experience

Comments

@jankeromnes
Copy link
Contributor

Follow-up to #5474

In the Prebuild page, there is a New Workspace button, with the intent to allow starting workspaces from a Prebuild.

Screen Shot 2021-09-03 at 11 09 34

Currently, the button opens the original context URL of the Prebuild (e.g. a branch, or a Pull Request URL). However, this is no longer the correct link if new commits have been pushed to the original branch.

We could either:

  • Better explain what the New Workspace button does and doesn't
  • Point the New Workspace button more precisely to a specific Prebuild, e.g. by linking to the original full commit URL that this Prebuild was built for
  • Remove the New Workspace button

See also

Suggestion to remove: #5474 (comment)

One question to the New Workspace button on the Prebuild page: is it practical? You cannot start a workspace for old prebuilds anyways, so the page is more of a view. Wdyt of removing it from there?

Suggestion to keep and rename the button: #5474 (comment)

I'd opt to leave it here. I was just using it and didn't have any doubts that it was handy there. It should maybe show what it does (Open workspace on branch branch-name) in the tooltip.

Suggestion to link to a commit context URL: #5474 (comment)

Or, we can still link to the exact (potentially outdated) prebuild by using the commit context URL.

But maybe after using it for a bit we'll know more about what's better here.

@JanKoehnlein
Copy link
Contributor

@gtsiolis can you decide from the UX perspective and make this actionable?

@svenefftinge svenefftinge self-assigned this Sep 28, 2021
@stale
Copy link

stale bot commented Feb 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 20, 2022
@stale stale bot closed this as completed Mar 15, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: stale This issue/PR is stale and will be closed soon roadmap item: teams & projects type: improvement Improves an existing feature or existing code user experience
Projects
Archived in project
Status: Needed for shipping 🚢
Development

No branches or pull requests

4 participants