Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some failed prebuilds use a wrong status label #5611

Closed
gtsiolis opened this issue Sep 8, 2021 · 8 comments
Closed

Some failed prebuilds use a wrong status label #5611

gtsiolis opened this issue Sep 8, 2021 · 8 comments
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 8, 2021

Bug description

Some failed prebuilds use a wrong status label.

Prebuilds List Prebuild Page
Screenshot 2021-09-08 at 7 43 36 PM Screenshot 2021-09-08 at 7 43 48 PM

Steps to reproduce

N/A

Expected behavior

No response

Example repository

See prebuild for gitpod-io/gitpod in gitpod.io.

Anything else?

No response

@gtsiolis gtsiolis added type: bug Something isn't working user experience component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Sep 8, 2021
@AlexTugarev
Copy link
Member

@gtsiolis does it stay like this on the Prebuild Page on reload after +10 seconds?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 9, 2021

@AlexTugarev yes, you can also try this using the example link above:

https://gitpod.io/t/gitpod/gitpod/5a09fc7e-40c6-4549-b785-ece367564c96

@gtsiolis
Copy link
Contributor Author

This seems to be still an issue, see another example:

https://gitpod.io/t/gitpod/gitpod/bb33f016-55a3-43e7-a8a2-e875a74effe4

However, let's move this to the Next Iteration in the relevant project board[1] as this affects a really small set of prebuilds.

Prebuilds List Prebuild
p-1 p-2

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 24, 2021

Indeed, good catch!

I think that in some cases, when the prebuild instance fails (i.e. the WorkspaceInstance has a failure condition and stops), for some reason the prebuild status is not updated (i.e. PrebuiltWorkspace remains in state = 'building'?).

EDIT: Ah, if I remember correctly, I think this might be the case when the prebuild instance cannot even start.

@stale
Copy link

stale bot commented Dec 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 23, 2021
@gtsiolis
Copy link
Contributor Author

No longer relevant as we do not include the second status label in the header.

However, we still need to handle links to 🅰️ deleted prebuilds like the one linked in the issue description and 🅱️ non-existent prebuilds. Cc @jldec

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Dec 27, 2021
@stale
Copy link

stale bot commented Mar 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 28, 2022
@easyCZ
Copy link
Member

easyCZ commented Apr 4, 2022

This issue has been resolved in #8805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working user experience
Projects
Archived in project
Status: Next iteration 🛹
Development

No branches or pull requests

4 participants