Skip to content

Simplify the Project Configuration page by using the Workspace Start page to show Prebuild logs #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Sep 21, 2021 · 6 comments
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. groundwork: in progress needs visual design team: webapp Issue belongs to the WebApp team user experience

Comments

@svenefftinge
Copy link
Member

Instead of showing the logs on the right handside we should just forward to running workspace with prebuild.
This will make it simpler for us and users, because the loading screen is already more mature and users will end up in a new workspace (they even have all the capabilities to skip prebuild, use default images, etc.)
Furthermore the UI is less crowded (more space for the editor).

We should also communicate that this will start a prebuild and workspace on a the default branch.

@svenefftinge svenefftinge added the feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. label Sep 21, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 21, 2021

I agree that this change has a lot of benefits, and see the following pros and cons (mostly the same as what you said):

Pros:

  • Simplifies the Configurator UI (becomes just an editor)
  • Simplifies the dashboard (goes from 3 different "Prebuild views" to just 2: the logs of a Prebuild, and "Prebuild in Progress" in start screen)
  • Better reflects the different prebuild stages (image build, allocating resources, pulling image, etc) and allows skipping etc
  • Removes one step before you're inside a workspace (i.e. no second click needed after "Run & Open Prebuild")

Cons:

  • Removes the ability to "iterate quickly" (e.g. if there is an error in the config, there is no obvious way to "go back + fix the config + retry")

I'm just uncertain whether it's better to implement this change before or after general release of Teams & Projects. (Maybe a proof-of-concept PR could help us decide?)

@JanKoehnlein
Copy link
Contributor

Seems like this needs more discussion to be actionable. Removing it from groundwork.

@jldec jldec changed the title [Configurator] Delegate to regular workspace start with prebuild Simplify the Project Configuration page by using the Workspace Start page to show Prebuild logs Oct 28, 2021
@jldec jldec moved this to In Groundwork in 🍎 WebApp Team Nov 21, 2021
@jldec
Copy link
Contributor

jldec commented Nov 23, 2021

/schedule

As discussed with @AlexTugarev I would like to include this issue as a candidate for this week's push toward simplifying and improving the usabilty of the conifiguration page.

@roboquat
Copy link
Contributor

@jldec: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

As discussed with @AlexTugarev I would like to include this issue as a candidate for this week's push toward simplifying and improving the usabilty of the conifiguration page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexTugarev
Copy link
Member

Resolved in #7088

Repository owner moved this from In Groundwork to Done in 🍎 WebApp Team Dec 9, 2021
@jldec
Copy link
Contributor

jldec commented Dec 12, 2021

Hi @AlexTugarev - The Configuration page is still in use.
Why do you still think this issue no longer applies there?

@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. groundwork: in progress needs visual design team: webapp Issue belongs to the WebApp team user experience
Projects
Archived in project
Development

No branches or pull requests

7 participants