Gitpod VSC loading screen should respect my dark theme setting

[schickling]

The Gitpod loading screen (before VSC is loaded) should respect my dark theme setting.

CleanShot.2021-11-15.at.15.51.47.mp4

[schickling]

[gtsiolis]

Thanks for noticing @schickling! Could not agree more. I also noticed this earlier last week but could not reliably reproduce. Looping in @jankeromnes in case they have any insights on why this is happening. ❓

FYI, we've recently added system theme support for the editor, see #6403 and we're also considering changing dashboard default theme to system for new users, see #6395. 🗺️

[pawlean]

Honestly, this issue should be prioritised alone after the use of that GIF. Thanks for the laugh @schickling!

[jankeromnes]

Agree, thanks for this issue!

I'm just confused as to why "Checking" is in Dark theme while "Creating" is in Light theme 🤔

@schickling Which dashboard "Theme" do you currently have selected in https://gitpod.io/preferences ? (This is what controls the color of non-workspace Gitpod pages, and as @gtsiolis mentioned it's currently Light by default, but should instead be System by default -- will fix this soon)

[schickling]

[gtsiolis]

@jankeromnes is this also resolved with #6747? Cc @AlexTugarev

[jankeromnes]

Probably yes, but if both dashboard and OS preference were already dark, and the loading screen still flashed white, I suspect there could also be a different bug hidden here.

Maybe safer to wait a bit and see if this issue still reproduces now that #6747 got merged and deployed?

[gtsiolis]

Closing this as seems to be resolved with the deployed changes in #6747.