Skip to content

Allow enabling/disabling Incremental Prebuilds in a Project's settings #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Nov 16, 2021 · 6 comments · Fixed by #7031
Closed

Allow enabling/disabling Incremental Prebuilds in a Project's settings #6727

jankeromnes opened this issue Nov 16, 2021 · 6 comments · Fixed by #7031
Assignees
Labels
aspect: performance anything related to performance component: dashboard feature: prebuilds groundwork: awaiting deployment self-hosted team: webapp Issue belongs to the WebApp team type: feature request New feature or request type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Nov 16, 2021

Is your feature request related to a problem? Please describe

We have a feature called Incremental Prebuilds that can create new Prebuilds on top of older (compatible & successful) Prebuilds.

This feature can significantly speed up Prebuilds for projects that take > 10 minutes to build. (⚠️ For projects that take < 10 minutes to build, Incremental Prebuilds doesn't yield a significant speed-up and can actually even slow them down.)

However, only Gitpod developers can enable or disable it for specific repositories today (by editing server.incrementalPrebuilds.repositoryPasslist in this internal config file and re-deploying Gitpod).

Describe the behaviour you'd like

It would be great if users could opt-in or opt-out of Incremental Prebuilds directly from their Project's settings, e.g. with a checkbox like this:

Project Settings

  • Use Incremental Prebuilds (beta)

Describe alternatives you've considered

Additional context

@jankeromnes jankeromnes added type: feature request New feature or request feature: prebuilds type: improvement Improves an existing feature or existing code aspect: performance anything related to performance team: webapp Issue belongs to the WebApp team labels Nov 16, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 16, 2021

Thanks for opening this, @jankeromnes!

FWIW, this was also brought up in a recent product sync meeting (internal). The consensus was also to go with a project settings option. Cc @jldec @atduarte @csweichel @svenefftinge

suggestion: I'd suggest to include some help text to describe what is this feature and how a project could benefit.

question: Could we detect whether this is suggested for a repository? For example, we could nudge users to enable incremental prebuilds when prebuilds for example take more than X minutes? Similarly, we could nudge users to disable the feature when prebuilds less than X minutes let's go with the first approach in the first iteration and get some data around usage. Does this make sense?

@jankeromnes
Copy link
Contributor Author

Added self-hosted label as requested by @metcalfc 👋

@jldec jldec moved this to In Groundwork in 🍎 WebApp Team Nov 21, 2021
@jankeromnes
Copy link
Contributor Author

Happy to take this once once it gets scheduled.

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 29, 2021

Proof-of-concept: https://github.com/gitpod-io/gitpod/compare/jx/incremental-prebuild-settings

Screenshot 2021-11-29 at 13 23 05

@jankeromnes
Copy link
Contributor Author

Actually my proof-of-concept is nearly complete, so might as well schedule and raise a Pull Request.

Happy to iterate on the UX in the PR 😇

/schedule

@roboquat
Copy link
Contributor

roboquat commented Dec 1, 2021

@jankeromnes: Issue scheduled in the meta team (WIP: 0)

In response to this:

Actually my proof-of-concept is nearly complete, so might as well schedule and raise a Pull Request.

Happy to iterate on the UX in the PR 😇

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from In Groundwork to Done in 🍎 WebApp Team Dec 14, 2021
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: performance anything related to performance component: dashboard feature: prebuilds groundwork: awaiting deployment self-hosted team: webapp Issue belongs to the WebApp team type: feature request New feature or request type: improvement Improves an existing feature or existing code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants