Skip to content

[installer] mysql helm global.storageClass may need to be set #6789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metcalfc opened this issue Nov 18, 2021 · 7 comments
Closed

[installer] mysql helm global.storageClass may need to be set #6789

metcalfc opened this issue Nov 18, 2021 · 7 comments
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team

Comments

@metcalfc
Copy link
Contributor

I set a default storage class:

kubectl patch storageclass local-path -p '{"metadata": {"annotations":{"storageclass.kubernetes.io/is-default-class":"true"}}}'

minio and registry respect that. mysql does not. In the Bitnami Helm chart the option is:

global.storageClass and by default its nil

When we render it down we might have to give it a value?

@metcalfc
Copy link
Contributor Author

I tried adding a StorageClassName on the volumeClaimTemplates:

  volumeClaimTemplates:
    - metadata:
        name: data
        labels:
          app.kubernetes.io/name: mysql
          app.kubernetes.io/instance: MySQL
          app.kubernetes.io/component: primary
      spec:
        accessModes:
          - "ReadWriteOnce"
        resources:
          requests:
            storage: "5Gi"
        storageClassName: "local-path"

Its not flowing through to the StatefulSet.

 k describe pvc data-mysql-0
Name:          data-mysql-0
Namespace:     default
StorageClass:
Status:        Pending
Volume:
Labels:        app.kubernetes.io/component=primary
               app.kubernetes.io/instance=MySQL
               app.kubernetes.io/name=mysql
Annotations:   <none>
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:
Access Modes:
VolumeMode:    Filesystem
Used By:       mysql-0
Events:
  Type    Reason         Age                  From                         Message
  ----    ------         ----                 ----                         -------
  Normal  FailedBinding  25s (x142 over 35m)  persistentvolume-controller  no persistent volumes available for this clai

I've also set a default storageclass. So I would have thought it would have just been picked up.

k describe storageclasses.storage.k8s.io
Name:            local-path
IsDefaultClass:  Yes

@metcalfc
Copy link
Contributor Author

Kubernetes is a journey.

We should likely require a default storage class or let folks set it.

@metcalfc
Copy link
Contributor Author

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 27, 2022
@lucasvaltl
Copy link
Contributor

@Pothulapati could you take a look at this? This might be related to the work you are doing regarding post-processing in the #9075 and if we have a good fix there it might help with this issue as well.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 17, 2022
@lucasvaltl
Copy link
Contributor

@mrsimonemms could you please also check here if this is still relevant?

@mrsimonemms
Copy link
Contributor

I'm going to close this as "not planned". There's been no other mention of this since November as in-cluster MySQL has sort of evolved as the backup choice - the preferred, enterprise-grade solution is always to use a managed/external database.

@mrsimonemms mrsimonemms closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2022
Repository owner moved this from 🧊Backlog to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team
Projects
No open projects
Development

No branches or pull requests

4 participants