Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Infer .gitpod.yml #6921

Closed
svenefftinge opened this issue Nov 26, 2021 · 1 comment · Fixed by #7383
Closed

Always Infer .gitpod.yml #6921

svenefftinge opened this issue Nov 26, 2021 · 1 comment · Fixed by #7383
Assignees
Labels
team: webapp Issue belongs to the WebApp team type: feature request New feature or request

Comments

@svenefftinge
Copy link
Member

svenefftinge commented Nov 26, 2021

Since we now have the possibility to infer a .gitpod.yml and start a workspace with it so that the derived config file is added to the workspace's project folder. I think we can do this always if there is no .gitpod.yml.

see also #6922

@jankeromnes
Copy link
Contributor

On second thought, it's probably a bit too early to put this into Groundwork.

Let's revisit this in a few weeks.

@svenefftinge svenefftinge self-assigned this Dec 29, 2021
@svenefftinge svenefftinge moved this to In Groundwork in 🍎 WebApp Team Dec 29, 2021
@roboquat roboquat moved this to Done in 🍎 WebApp Team Dec 30, 2021
filiptronicek pushed a commit that referenced this issue Jan 5, 2022
Add the TrackEvent type struct

Reference fixes

Only require one flag

Better function description

go fmt

Update components/gitpod-cli/cmd/git-track-command.go

Co-authored-by: bigint <bigint@icloud.com>

fixes

Log the correct vars and correct error messages

Set test data

Remove more unused code

go fmt

More go fmt

Mock `TrackEvent`

Fix destination of `gitCommand`

Fix function references

Spawn the git command tracker automatically

Correct the script name

Don't expect any results

Don't return on error with tracker

Use new connection syntax

`go fmt`

Set the correct type for params, rename args

`go fmt`

Fix param type names

Add resource scope

Move process release to an `else` block

Make `TrackEvent` types emulate the backend

Format

`go fmt`

Only use the one required scope

Close the client after returning

Change description

[changelog] updated changelog

Setup IdentitiesOnly as yes in ssh config

Fixes #7335

Handle "no data" by adding 'on() vector(0)' to each numerator
Relies on new variable $datasource
Also fixes legend for workspace startup panel
When exporting from Grafana, disable "export for sharing externally"

Helm is needed to support Observability

[changelog] updated changelog

add missing condition for ide-proxy heml chart

Improve label colors on dashboard integrations for the dark theme

Send headers when connecting to the supervisor

Create the version file during build

Setup IdentitiesOnly as yes in ssh config

Fixes #7335

Handle "no data" by adding 'on() vector(0)' to each numerator
Relies on new variable $datasource
Also fixes legend for workspace startup panel
When exporting from Grafana, disable "export for sharing externally"

Helm is needed to support Observability

[changelog] updated changelog

add missing condition for ide-proxy heml chart

Improve label colors on dashboard integrations for the dark theme

Fix Gitpod casing in proc tests

[local-app] timeout the local app after special time of inactivity

Set hostname to workspace ID rather than instance ID

removed unused dependency

[server] derive configuration when no explicit one

Fixes #6921

[changelog] updated changelog

Add version command

Make the command available

`go fmt`

Try adding dummy version file

Move the text file again

Print the trimmed version

Use the version string from the gitpod client component

Remove unused version file
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team type: feature request New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants