Skip to content

Fix "Flash Of Unstyled Content" in new login screen #7138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Dec 9, 2021 · 3 comments
Closed

Fix "Flash Of Unstyled Content" in new login screen #7138

jankeromnes opened this issue Dec 9, 2021 · 3 comments
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Dec 9, 2021

Bug description

There is a "Flash Of Unstyled Content" in Gitpod's new context-aware login screen.

Screencast (where I reload multiple times to show the problem):
https://youtu.be/Z8RAFGaXHuY

Steps to reproduce

  1. Make sure you're rolled into the new login screen experiment (in a browser console on gitpod.io)
localStorage['gitpod-ui-experiments'] = '{"login-from-context-6826":true}';
  1. Log out of gitpod.io

  2. Visit https://gitpod.io/#https://github.com/gitpod-io/gitpod and see the new login screen

There is a "Flash Of Unstyled Content" when you (re)load it (i.e. it first renders something, then re-renders something different, causing a briefly unstable UI).

Here is a screencast where I refresh multiple times to show the problem:
https://youtu.be/Z8RAFGaXHuY

Workspace affected

No response

Expected behavior

The initial rendering should be stable (i.e. render the correct UI in one shot).

Example repository

No response

Anything else?

No response

@jankeromnes jankeromnes added component: dashboard type: improvement Improves an existing feature or existing code aspect: performance anything related to performance team: webapp Issue belongs to the WebApp team labels Dec 9, 2021
@jldec
Copy link
Contributor

jldec commented Dec 12, 2021

/schedule

@roboquat
Copy link
Contributor

@jldec: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Apr 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 3, 2022
@stale stale bot closed this as completed Apr 14, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Archived in project
Development

No branches or pull requests

3 participants