Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket provider does not return isDefault #7325

Closed
jmls opened this issue Dec 21, 2021 · 4 comments · Fixed by #7371
Closed

Bitbucket provider does not return isDefault #7325

jmls opened this issue Dec 21, 2021 · 4 comments · Fixed by #7371

Comments

@jmls
Copy link

jmls commented Dec 21, 2021

Bug description

when trying to run a prebuild in the dashboard , a bitbucket repo returns the error

"Error: Could not find a default branch in repository"

Steps to reproduce

image

press the "run preview" button and you get this error

image

Workspace affected

any bitbucket repo

Expected behavior

it should behave the same way as gitlab and github - ie run a prebuild

Example repository

No response

Anything else?

It looks like the Bitbucket API on a repo / branch does not return the information needed to check if the branch is the default.

the gitlab code is

return { host, owner, name, cloneUrl, description, avatarUrl, webUrl, defaultBranch };

the bitbucket code is

return { host, owner, name, cloneUrl, description, avatarUrl, webUrl };

There is an api call in BitBucket to obtain the default branch , but this is not implemented in the BitBucket provider code from gitpod.

@gtsiolis
Copy link
Contributor

Thanks for reporting this, @jmls!

This is probably related to #7366 as the default branch is also not detected in the Branches page.

Cc @AlexTugarev @jldec because #7251

@gtsiolis
Copy link
Contributor

/assign @trumbitta

@roboquat
Copy link
Contributor

@gtsiolis: GitHub didn't allow me to assign the following users: trumbitta.

Note that only gitpod-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @trumbitta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldec
Copy link
Contributor

jldec commented Jan 2, 2022

/schedule

@jldec jldec moved this to Scheduled in 🍎 WebApp Team Jan 2, 2022
@jldec jldec moved this from Scheduled to In Review in 🍎 WebApp Team Jan 2, 2022
@AlexTugarev AlexTugarev added the do-not-merge/cla-pending CLA has not been signed label Jan 3, 2022
@AlexTugarev AlexTugarev self-assigned this Jan 3, 2022
@AlexTugarev AlexTugarev removed their assignment Jan 3, 2022
@AlexTugarev AlexTugarev removed the do-not-merge/cla-pending CLA has not been signed label Jan 3, 2022
Repository owner moved this from In Review to Done in 🍎 WebApp Team Jan 3, 2022
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants