Skip to content

Adding a project for a Bitbucket repository will not trigger any prebuilds or add any webhooks #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Dec 27, 2021 · 5 comments · Fixed by #7422
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. git provider: bitbucket groundwork: awaiting deployment team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 27, 2021

Problem to solve

Back in #7251, we've added support for Bitbucket projects.

However, when adding a project for a Bitbucket repository will not trigger any prebuilds or add any webhooks. See relevant comment in #7251 (comment):

... in contrast with GitLab and GitHub repositories, adding a Bitbucket repository 🅰️ does not add a webhook for enabling prebuilds and 🅱️ does not automatically trigger a first prebuilds after adding the project.

Proposal

Let's 🅰️ add a webhook when adding a Bitbucket repository and 🅱️ trigger a prebuild when adding the project to follow the behavior of the product when adding GitLab and GitHub repositories as projects.

Cc @AlexTugarev in case adding the webhook is not the best way forward here.

@gtsiolis gtsiolis added git provider: bitbucket component: dashboard type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Dec 27, 2021
@jldec
Copy link
Contributor

jldec commented Dec 27, 2021

Thanks for opening this followup issue @gtsiolis
We should (within reason) try to offer a consistent UX for projects across git providers.
/schedule

@roboquat
Copy link
Contributor

@jldec: Issue scheduled in the meta team (WIP: 0)

In response to this:

Thanks for opening this followup issue @gtsiolis
We should (within reason) try to offer a consistent UX for projects across git providers.
/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldec
Copy link
Contributor

jldec commented Jan 3, 2022

The fix for this issue should result in the equivalent of enabling prebuilds with a prefixed /#prebuild URL.

Users should not have to use the manually prefixed URL for prebuilds. This is important because (from #6688 (comment))

Also, the manual prefix implementation is no longer correct (it doesn't associate Projects to prebuilds, doesn't use Incremental Prebuilds if enabled, etc).

cc: @gtsiolis @AlexTugarev

@AlexTugarev
Copy link
Member

@jldec and @gtsiolis, just to clarify what enablement of prebulids means as it is implemented currently: two things needs to be true in order for a prebuild to start on a new commit. first the app/webhook needs to be installed to get the push event into Gitpod, and then the event handler needs to find/evaluate a Gitpod config for this repo to decide if a prebuild should be started.

PR #7422 targets only the creation of a missing webhook. if the config+tasks do not exist in the repo, prebuilds won't be triggered automatically.

@jldec
Copy link
Contributor

jldec commented Jan 4, 2022

PR #7422 targets only the creation of a missing webhook. if the config+tasks do not exist in the repo, prebuilds won't be triggered automatically.

That matches my expectations @AlexTugarev
I was just a bit confused by comments in the PR and in #7424. - sorry about that

Repository owner moved this from In Review to Done in 🍎 WebApp Team Jan 4, 2022
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. git provider: bitbucket groundwork: awaiting deployment team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants