Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the save button with the button component with a loading state viarant #7385

Open
jldec opened this issue Dec 29, 2021 · 6 comments
Open
Labels
component: dashboard feature: dotfiles meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jldec
Copy link
Contributor

jldec commented Dec 29, 2021

The initial Beta implementation (PR #7337) of Dotfiles support uses a simple text input for users to configure the URL of their dotfiles repository.

This issue defines a repo-selection UI to make this process more friendly by allowing users to search for and select their dotfiles repo without leaving the dashboard.

Proposed specifiication

  • Select any repo under your personal account (users must clone first if they want to use a 3rd-party dotfiles repo).
  • Choose from repos from any existing git provider integration.
  • Don't offer to add new git provider integrations inside the repo selection flow, instead link to the main integrations setttings page (leaving the flow).
@PatMyron
Copy link

Would love it to default if a repo is named dotfiles:
#7337 (comment)

@stale
Copy link

stale bot commented Sep 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 9, 2022
@stale stale bot closed this as completed Sep 25, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Sep 25, 2022
@gtsiolis gtsiolis removed their assignment Sep 26, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Sep 26, 2022
@gtsiolis gtsiolis reopened this Sep 26, 2022
Repository owner moved this from Done to In Progress in 🍎 WebApp Team Sep 26, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 14, 2022

The UX around setting and managing .dotfiles could definitely benefit from another iteration. ➿

Posting below some early designs from a past exploration:

Disabled .dotfiles Enabled .dotfiles
Disabled Enabled
Preferences (Unset) Preferences (Select)
Empty ModalDefaultAlternative-1

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 5, 2023

This could probably now re-use the repository selection dropdown from #15287 (comment). We would only need an action to clear the selection. Cc @svenefftinge

BEFORE AFTER
dtofiles-before dtofiles-after

@gtsiolis
Copy link
Contributor

Now that we have a button component with a loading variant (see relevant PR Cc @selfcontained) we could drop and replace that there as the next iteration.

@gtsiolis gtsiolis changed the title Repo Selection UI for dotfiles configuration Replace the save button with the button component with a loading state viarant Mar 23, 2023
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 23, 2023

Re-purposed this issue to something simpler, like replacing the save button with the button with a loading state variant.

@gtsiolis gtsiolis mentioned this issue Mar 30, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: dotfiles meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: In Progress
Development

No branches or pull requests

5 participants