Adding a Button component #16592
Merged
Adding a Button component #16592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-bmh-button-component.2 because the annotations in the pull request description changed |
|
/werft run with-preview=true 👍 started the job as gitpod-build-bmh-button-component.3 |
|
/werft run with-clean-slate-deployment=true recreate-vm=true 👍 started the job as gitpod-build-bmh-button-component.4 |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
selfcontained
force-pushed
the
bmh/button-component
branch
from
95d6011 to
3ee2e6b
Compare
easyCZ
approved these changes
Mar 2, 2023
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new
<Button/>component to normalize how we use buttons and how they appear. Still more details we can work through as we apply this to other spots using vanilla<button>tags, but this is a start that works for the use cases below.Updated the following locations to use the new component, as they provided a variety of styles.
loadingstateRelated Issue(s)
Fixes #16441
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh