Skip to content

Introduce project settings for enabling prebuilds for branches, pull requests, etc. #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gtsiolis opened this issue Jan 3, 2022 · 7 comments
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team type: feature request New feature or request

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 3, 2022

Problem to solve

Following the problem statement in #7425, 🅰️ prebuilds are only enable for Github repositories for the default branch and 🅱️ prebuilds are not enabled when adding a repository as project.

For GitHub repositories, when installing the GitHub App, prebuilds are enabled by default for the default branch. For enabling prebuilds for all branches, a user will need to defien this in .gitpod.yml, see relevant docs.

For GitLab and Bitbucket repositories, when adding aproject a webhook is installed. However, enabled are not enabled, see #7424 and pending PR in #7422. Prebuilds are also not enabled when adding a project, following the pattern used for GitHub repositories.

This makes enabling prebuilds for all branches a less discoverable option and more difficult to set up.

Proposal

Introduce a preference in project settings that allows enabling or disabling prebuilds for a) branches, b) pull requests, c) pull requests from forks, as well as, enabling or disabling e) add check, f) add comment, and g) add badge.

@gtsiolis gtsiolis added type: feature request New feature or request component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team needs ux input 🍊 needs visual design labels Jan 3, 2022
@jldec
Copy link
Contributor

jldec commented Jan 3, 2022

thank you @gtsiolis - i have added this to our prebuilds investigations / backlog.

@jldec
Copy link
Contributor

jldec commented Jan 9, 2022

@gtsiolis would you mind correcting the description above given that new projects do enable prebuilds across git providers now.

Also regardig the proposal, could you please explain the benefit of moving this configuration out of .gitpod.yml and into the project settings? I would suggest that simply removing the "github" scope of the current configuration, but leaving it in .gitpod.yml just like today is a simpler, and more portable solution.

@jmls
Copy link

jmls commented Jan 31, 2022

I would like to have an option to configure prebuilds per branch. Running into some really strange errors starting up a workspace if there is a prebuild running (can't find a user variable defined as available to scope /

@jldec
Copy link
Contributor

jldec commented Jan 31, 2022

@jmls - if you can repro the strange errors you mentioned ☝️ or still have it open, would you mind providing some more details? (repo / project / name of workspace / copy of error message) thanks!

@apolopena
Copy link

Yeah I work on branches testing gitpod configurations quite often and having prebuilds turned off for gitpod workspace images increases testing time by 100%. This feature would be really nice to have.

In fact correct me if I am wrong but I remember a time when all gitpod workspace images were prebuilt by default no matter what.

@stale
Copy link

stale bot commented May 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 30, 2022
@shaal
Copy link
Contributor

shaal commented Jun 2, 2022

Perhaps add the label meta: never-stale ?

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 2, 2022
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team type: feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

5 participants