Gitpod badge is not displayed when PR doesn't have description

[shaal]

Bug description

After adding addBadge: true to .gitpod.yml

github:
  prebuilds:
    # add a "Open in Gitpod" button to the pull request's description (defaults to false)
    addBadge: true

When creating a new PR with no description, a Gitpod badge is not added to PR description.

Steps to reproduce

Make sure your repo has this code in .gitpod.yml -

github:
  prebuilds:
    # add a "Open in Gitpod" button to the pull request's description (defaults to false)
    addBadge: true

Create a new PR, make sure to only give a title to the PR, but no descirption.
Confirm that the PR has no Gitpod badge in its description.

Workspace affected

No response

Expected behavior

When addBadge: true is added to .gitpod.yml, I expect the Gitpod badge to be displayed in all PRs, including PRs without a descirption.

Example repository

https://github.com/shaal/gitpod-test--no-gitpod-badge-in-pr-without-description

I created 2 PRs -

• PR with description (work as expected, Gitpod badge is displayed) - PR with description - Gitpod badge is displayed shaal/gitpod-test--no-gitpod-badge-in-pr-without-description#2
• PR without description (this is the bug, no Gitpod badge is displayed) - PR w/o description- Gitpod bot ran,no Gitpod badge shaal/gitpod-test--no-gitpod-badge-in-pr-without-description#1

Anything else?

No response

[gtsiolis]

Thanks for the detailed write up, @shaal! I remember seeing a similar report from @JanKoehnlein in #3812.

This is also something to consider introducing as a preference in project settings, see #7426.

[NotNoah]

Any word on if this can be fixed? We quite often have Pull Requests with no description as all the info is usually in our PR titles

[RCheesley]

We also have this happening in multiple repos for mautic!

[Siddhant-K-code]

Maybe Following will fix this

gitpod/components/server/ee/src/prebuilds/github-app.ts

Line 573 in 9f8bf5f

const body: string | null = pr.body;

- const body: string | null = pr.body;
+ const body: string = pr.body | ""; 

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.