Skip to content

Design improvements for the new "New Workspace" modal #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Feb 8, 2022 · 6 comments
Closed

Design improvements for the new "New Workspace" modal #8088

jankeromnes opened this issue Feb 8, 2022 · 6 comments
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Feb 8, 2022

Suggested improvements

Based on discussion (internal)

  1. Recover behavior to show recents by default (#8380 ✅)

    • Autopopulate results even when input is empty
    • Tweak result ranking to show recents first
    • Remove current help text
    • Set placeholder = “Paste repository URL or type for suggestions”
  2. Result rendering - visually break down repo URLs into multiple lines

    For results based on existing repositories:

    repo-name
    <git provider>/<org-or-user-or gitlab-group...> (wrapped?)
    issue-pr-commit-context (optional?)

    For pasted URLS:

    https://pasted-url/...

  3. Modal UX and styles

    • grey background [1].
    • text input consistency: focus/active state colors
    • bold grey vs soft grey selection
    • tweak modal size (may affect all modals - ok)
    • (lower priority - only if time permits) results found at bottom vs. infinite scroll
    • make sure the scrolling area is clear to the user[1]
  4. (Optional) Results visual differentiation

    • history / recent worspaces
    • own repos
    • examples

Current design

Screenshot 2022-02-08 at 12 10 53 Screenshot 2022-02-08 at 12 13 43 Screenshot 2022-02-08 at 12 12 49 Screenshot 2022-02-08 at 12 14 10
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Feb 8, 2022

We could also bake in this requirement here:

  • A larger, cleaner user interface

I think we could even make all modals a bit larger, as suggested (internal) by @geropl:

🧵 While having a look at #7715 in noticed something that is tickling me for a while now: Can we make our modals a tad bigger? 🙃

IMO that would help with:

  • settings focus on the modal
  • auto-wrap of context URLs in various places
  • the "cramped" feeling the modal gives

@jankeromnes
Copy link
Contributor Author

Cool suggestion from @felladrin on Slack (internal):

In the modal's current empty state, the text "Example repositories" could be a link, which either:

Current empty state Proposal 🅰️ (pre-fill) Proposal 🅱️ (link)
Screenshot 2022-02-09 at 17 05 33 Screenshot 2022-02-09 at 17 31 38 Screenshot 2022-02-09 at 17 34 50

@felladrin
Copy link
Contributor

Another suggestion: disable spell checking, autocomplete, and autocorrect on the input field, by adding these attributes to the html input tag: autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"

@jldec
Copy link
Contributor

jldec commented Feb 10, 2022

@jankeromnes - I have updated the description above based on our discussion.
@gtsiolis - If you have a figma design which which matches the new outlined changes, please add image inline above.

@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 25, 2022
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label May 26, 2022
@jankeromnes jankeromnes removed the meta: stale This issue/PR is stale and will be closed soon label Jun 8, 2022
@jankeromnes jankeromnes removed their assignment Jun 8, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 5, 2023

Closing this as the next iteration for improving the new workspace modal has been added in #15389. Cc @svenefftinge

There are still lots of improvements we could make like structure and visual improvements, but I'll close this as this issue lacks a clear problem statement and proposal.

@gtsiolis gtsiolis closed this as completed Jan 5, 2023
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: In Validation
Development

No branches or pull requests

4 participants