Skip to content

Settings page on mobile layout #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4050
krystxf opened this issue Feb 10, 2022 · 6 comments · Fixed by #17010
Closed
Tracked by #4050

Settings page on mobile layout #8133

krystxf opened this issue Feb 10, 2022 · 6 comments · Fixed by #17010
Labels
meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: feature request New feature or request

Comments

@krystxf
Copy link
Contributor

krystxf commented Feb 10, 2022

It would be nice to have a responsive settings page. Probably with some sort of drop down menu instead of the side menu on mobile. I'm willing to help with the styling, but I need some suggestions to get it the way you'd like.

@krystxf krystxf changed the title Settings mobile layout Settings page mobile layout Feb 10, 2022
@krystxf krystxf changed the title Settings page mobile layout Settings page on mobile layout Feb 10, 2022
@pawlean pawlean added team: webapp Issue belongs to the WebApp team type: feature request New feature or request labels Feb 10, 2022
@pawlean
Copy link
Contributor

pawlean commented Feb 10, 2022

Thanks for your feedback, @krystofex! I'm looping in @gtsiolis for information. 😊

@jldec
Copy link
Contributor

jldec commented Feb 10, 2022

Moved to investigating/visual-design

@gtsiolis
Copy link
Contributor

Thanks for opening this, @krystofex! This is related to the responsive layout of the dashboard in general, see also #4050.

Thanks for the ping @pawlean! 🏓

@gtsiolis
Copy link
Contributor

Regarding settings layout specifically, let me cross-post below an early design from a relevant discussion (internal).

Cross-posting also a relevant doc (internal) from @jankeromnes.

Screenshot 2021-07-07 at 2 12 47 PM

@jankeromnes
Copy link
Contributor

jankeromnes commented Feb 14, 2022

Awesome, many thanks for getting the ball rolling and offering to help here @krystofex! ♥️🚀📱

And thanks @gtsiolis for re-surfacing the initial designs!

I like many of their aspects.

  • For the top-right menu, I guess Admin, Docs and Help could indeed get folded into the Avatar drop-down menu on smaller screens
  • For the Settings menu (and other similar sub-menus), I'm not a big fan of the big drop-down selector. We used to have this on https://www.gitpod.io/docs/ and it felt a bit awkward/unfinished (now they have a nice "Go back to all topics" link / all topics page)
  • For the top-left menu, I'm not sure whether grouping into a drop-down makes sense, especially with our new "personal/team account selector with tabs beneath" UI

In any case, I do think maybe the top-left and top-right menus are out of scope here, since the issue specifically mentions the Settings menu. Focusing on the Settings sub-menu first makes sense.

I wonder how other apps with outstanding mobile UI have solved this problem.

@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 31, 2022
@stale stale bot closed this as completed Jun 28, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Jun 28, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Jun 28, 2022
@gtsiolis gtsiolis reopened this Jun 28, 2022
Repository owner moved this from Done to In Progress in 🍎 WebApp Team Jun 28, 2022
@geropl geropl removed the status in 🍎 WebApp Team Jul 6, 2022
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: feature request New feature or request
Projects
Status: In Validation
Development

Successfully merging a pull request may close this issue.

5 participants