-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] allow editing user information #11023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-sefftinge-allow-user-profile-updates-10999.1 because the annotations in the pull request description changed |
77276cc
to
eda0f85
Compare
eda0f85
to
04c5c35
Compare
Looking at this now! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX LAGTM (Looks Almost Good To Me)! Thanks, @svenefftinge!
Cross-posting a relevant issue in #3957 in case it can be also closed.
Left some minor comments below. We can open a follow-up issue for anything that can be skipped in this iteration.
04c5c35
to
ad017ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I think this is a good enhancement. A few comments.
-
Users ask to change their avatar almost as often as their name. (followup feature?)
-
Offering to change the name and email during sign-up flow is OK and may be a good opportunity to remind new users of our terms and privacy policy.
-
I was unable to test (in preview) whether this modal is triggered when an additional git integration is added through settings/integrations. Generally adding an integration should not result in modification of this information.
-
Including the hints for how to set env vars to override git email/author/committer is helpful, and I would not remove it.
/hold for more technical engineering review
Followup: I managed to test adding an integration using a non-incognito window, and it did not prompt for profile changes - so all good. (The error I saw earlier when trying to add an integration was using a preview environment from an incognito window.) |
ad017ac
to
d92f361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one more round of comments, mostly non-blocking. 🥊
Thanks for tackling all these in one step! 🙏
a81ea7c
to
8229fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the hold in case we'd like to:
1. Fix one outstanding UX issue mentioned in #11023 (comment).
2. Ask for another pair of eyes to take a closer look at the code changes. Cc @geropl
/werft run 👍 started the job as gitpod-build-sefftinge-allow-user-profile-updates-10999.9 |
@svenefftinge From the issues I don't understand how urgent this is. I feel we have a good opportunity to nicely solve our handling of email addresses if we delay it until end of next week and ask @AlexTugarev to clean it up beforehand (sth he's keen on for some time already, but ooo this week). |
/werft run 👍 started the job as gitpod-build-sefftinge-allow-user-profile-updates-10999.10 |
8229fb5
to
d2a1075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested and works 👍
Description
This change allows users to update their name, email and company name.

It also nudges users in the
workspaces view on the second day (or after) and then once a year.
Related Issue(s)
Fixes #10999
How to test
Use the preview env,
Release Notes
Documentation
Werft options: