Skip to content

Replace 'Company' with 'Company Name' in account profile #11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jldec opened this issue Jul 6, 2022 · 4 comments
Closed

Replace 'Company' with 'Company Name' in account profile #11182

jldec opened this issue Jul 6, 2022 · 4 comments
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Jul 6, 2022

Suggestion based on feedback (internal) to #11023
Screenshot 2022-07-05 at 16 43 40

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Jul 6, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 7, 2022

Things to consider before updating the text label:

  1. The term Company is the most common term for an input like this
  2. Using short terms when possible is preferred
  3. Name could be a bit ambiguous for a text label

Instead we could add a help text as seen in the initial specs, see #10999 (comment).

Account
Account-3

@phimae
Copy link

phimae commented Jul 7, 2022

had a short chat with @svenefftinge yesterday who gave some context: GitLab will pass the company domain instead of the name which is why he opted for name in the first place. This field is empty for existing users but will be pre-populated for new users that have the company or company domain property in their SCM

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 7, 2022

Thanks, @phimae!

This field is empty for existing users but will be pre-populated for new users that have the company or company domain property in their SCM

Agree, this makes sense. 💯

GitLab will pass the company domain instead of the name which is why he opted for name in the first place.

Using the domain here could be tricky or confusing to users without using any help text. 💭


Thinking about this again, unless this is against the initial product-led-growth reasons of this change, maybe it could help to also change the text label from Company to Organization to also support institutes, open source orgs[1], etc.?

@geropl geropl moved this to Clarification in 🍎 WebApp Team Jul 21, 2022
@geropl geropl moved this from Clarification to Scheduled in 🍎 WebApp Team Jul 21, 2022
@jldec jldec removed the status in 🍎 WebApp Team Aug 29, 2022
@stale
Copy link

stale bot commented Oct 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 20, 2022
@stale stale bot closed this as completed Nov 9, 2022
@stale stale bot moved this to In Validation in 🍎 WebApp Team Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

No branches or pull requests

4 participants