-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Analytics] Implement tracking for user profile changes #11176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run 👍 started the job as gitpod-build-jh-analytics-profile-changes.1 |
1812376
to
30364c0
Compare
30364c0
to
7f63454
Compare
@chrifro i added you as reviewer because of
|
const newProfile = { name: partialUser.fullName, ...partialUser.additionalData?.profile }; | ||
if (newProfile) { | ||
if ( | ||
!oldProfile || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: We already have similar functionality here. Actually, this whole section should be going into protocol.ts
, so it can be used from dashboard
and server
alike.
@jakobhero Do you want to do that? Or should I add a commit as suggestion on top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a commit if you want to 🍒-pick: b230334
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole section should be going into protocol.ts, so it can be used from dashboard and server alike.
makes sense!👍🏼
Here is a commit if you want to 🍒-pick: b230334
thanks for the 🍒!🙏🏼 i used hasChanges
to check before sending events, looks much cleaner now!
I guess we can only test this once the PR is merged? I'm not sure what you mean by "unverified email address reported by the user." Expected behavior: the information in customer.io is in sync with the dashboard. Once any information is changed in the dashboard, the information will be overwritten in customer.io as well. |
no, apologies for not being clearer. with this change, emails in customer.io will be overwritten by new email addresses that might not be real. when users are changing their emails in the profile, we are not taking any steps to verify that they're real nor have users confirm their new email address if they're changed in the profile section, which is a step down from using the trusted emails we get through the git authenticators (i assume they have to be verified for all of them before an account is created).
this is what's going to happen if this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice, looks good!
Description
Implements tracking for user-reported user profile changes implemented in #11023 by:
profile_changed
event with the old and new profile properties whenever the users submit a change to their profileidentify
call with the traits{ name, company, email}
whenever users submit a change to their profileNote that this change could potentially overwrite emails in tools such as customer.io with an unverified email address reported by the user.
How to test
Update Profile
profile_changed
event that details the changes and anidentify
event that contains the respective user attributes are sentRelease Notes
Documentation
Werft options: