Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace with phase "Timed out" refresh didn't restart #8246

Closed
mustard-mh opened this issue Feb 16, 2022 · 8 comments
Closed

Workspace with phase "Timed out" refresh didn't restart #8246

mustard-mh opened this issue Feb 16, 2022 · 8 comments
Labels
team: webapp Issue belongs to the WebApp team type: feature request New feature or request

Comments

@mustard-mh
Copy link
Contributor

mustard-mh commented Feb 16, 2022

Bug description

Workspace with phase "Timed out" refresh didn't restart. But with devTools Network, you can see that server has updated instance status with "running". And after refresh URL looks weird
https://gitpod.io/start/?not_found=true#gitpodio-ops-2v9ggs50f5l
https://gitpod.io/start/?not_found=true#gitpodio-ops-mpri4nsjyng

Click Open Workspace works

image

instance update get workspace
image image
Before refresh After Refresh
image image

Steps to reproduce

  1. Make workspace timeout
  2. Refresh

Anything else?

May be related to this PR? #8125

@mustard-mh mustard-mh added the team: webapp Issue belongs to the WebApp team label Feb 16, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Feb 16, 2022

May be related to this PR? #8125

Yes 🎯 the new behavior was made like this on purpose:

  • Before, we could have an infinite-redirect loop (e.g. on workspace fast crash) between /start/ and the IDE URL, causing a sort of Denial-Of-Service attack against ourselves
  • The new behavior no longer has this infinite-redirect problem (even on workspace fast crash), because it requires an explicit click on Open Workspace to actually restart the workspace

Our assumption was that, from a user experience perspective, it's okay to require an explicit click on Open Workspace before actually restarting the workspace on such a "stopped" (or "timed out") page. For example, in some cases maybe you didn't even want to restart the workspace (e.g. if you have several older stopped workspaces in your browser tabs, and you quickly cycle through your browser tabs, this might actually refresh and restart them all by accident).

Also, thanks a lot for your feedback. 🙏 Now we know for sure that some users actually relied on the old refresh-restart behavior.

If more users request to add the refresh-restart back (e.g. by commenting here or upvoting your issue with "👍"), we might need to reconsider.

@kylos101
Copy link
Contributor

kylos101 commented Mar 22, 2022

@jmls this is what we were just talking about 👋

(context: Julian works with Bitbucket, and has experienced this once before)

@geropl
Copy link
Member

geropl commented Mar 30, 2022

There there are multiple issues mixed in here:

  1. Refresh does not restart/re-open IDE: As @jankeromnes mentioned: the fact that we treat an instable state as instable is a feature, not a bug 🙃
  2. A re-started workspace page does still show "Timed Out" instead of "Running": that sounds like a bug, but I cannot reproduce it anymore 🤔
  3. The fact that supervisor/index.ts does not auto-reveal the IDE for a re-started workspaces when the state changes back to Running: This is what I wanted to get at with [supervisor] Ensure we fetch IDEOptions/desktopIDEConfig on re-start #8226. 💯

IMO we should think about closing this issue, and re-creating more specific ones.

@iurjoh
Copy link

iurjoh commented May 31, 2023

I am having this issue right now. How can I solve this?

@axonasif
Copy link
Member

axonasif commented Jun 1, 2023

Hi @iurjoh, is this still happening?

@rainerCH
Copy link

rainerCH commented Jun 5, 2023

i have this issue aswell since 2 days. how can i provide some informations to solve?

@axonasif
Copy link
Member

axonasif commented Jun 5, 2023

@rainerCH you can send us a message through https://www.gitpod.io/contact/support

@iurjoh
Copy link

iurjoh commented Aug 7, 2023

Hi @iurjoh, is this still happening?

I created a new workspace and leave the problem behind. I could not found any solution for this problem at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants