Skip to content

Remember last user choice for "auth provider" dropdown (client side) #8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geropl opened this issue Mar 2, 2022 · 5 comments
Open

Remember last user choice for "auth provider" dropdown (client side) #8524

geropl opened this issue Mar 2, 2022 · 5 comments
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@geropl
Copy link
Member

geropl commented Mar 2, 2022

@akosyakov reports:

that’s also annoying, always gitlab, although i logged in with github and change to it on this page each time:

image

@geropl geropl added good-first-issue component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Mar 2, 2022
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Mar 2, 2022
@geropl geropl removed the status in 🍎 WebApp Team Apr 14, 2022
@aboqasem
Copy link

Hi! I can't find a guide on how to contribute to the repository (e.g. running the project locally). When I try to yarn I get an error because a command requires go. I brew install go and rerun yarn:

-> yarn
yarn install v1.22.15
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > @testing-library/user-event@12.8.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > eslint-config-react-app@6.0.0" has unmet peer dependency "babel-eslint@^10.0.0".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > eslint-config-react-app@6.0.0" has unmet peer dependency "eslint-plugin-flowtype@^5.2.0".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > eslint-config-react-app@6.0.0" has unmet peer dependency "eslint-plugin-import@^2.22.0".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > eslint-config-react-app@6.0.0" has unmet peer dependency "eslint-plugin-jsx-a11y@^6.3.1".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > eslint-config-react-app@6.0.0" has unmet peer dependency "eslint-plugin-react@^7.20.3".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/dashboard > eslint-config-react-app@6.0.0" has unmet peer dependency "eslint-plugin-react-hooks@^4.0.8".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/server > @improbable-eng/grpc-web-node-http-transport@0.14.1" has unmet peer dependency "@improbable-eng/grpc-web@>=0.13.0".
warning "workspace-aggregator-61b88138-718a-472f-b7fe-2878cf3d0552 > @gitpod/supervisor-api-grpcweb > @improbable-eng/grpc-web@0.14.1" has unmet peer dependency "google-protobuf@^3.14.0".
[4/4] 🔨  Building fresh packages...
[10/11] ⠄ heapdump
[-/11] ⠄ waiting...
[-/11] ⠄ waiting...
[-/11] ⠄ waiting...
error /Users/aboqasem/dev/collab/gitpod/node_modules/@gitpod/licensor: Command failed.
Exit code: 2
Command: if [ ! -e ee/lib/liblicensor.a ]; then cd ee && go mod tidy -compat=1.18 -v && go build -buildmode=c-archive -o lib/liblicensor.a && go run genapi.go; fi
Arguments:
Directory: /Users/aboqasem/dev/collab/gitpod/node_modules/@gitpod/licensor
Output:
# golang.org/x/sys/unix
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/syscall_darwin.1_13.go:25:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
/Users/aboqasem/go/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable


A guide on how to install would be appreciated, then I would try to work on this issue.

@flaming-codes
Copy link

@aboqasem The readme is a bit hidden in this repo's /components/dashboard: https://github.com/gitpod-io/gitpod/tree/main/components/dashboard.

@gtsiolis
I think a link on the main readme would help quite a bit, e.g. a separate Contributing-section with links to the different onboarding guides, e.g. for dashboard.

@aboqasem
Copy link

aboqasem commented Jun 9, 2022

Thank you @flaming-codes! I will take a look at the issue.

Btw, the solution for the above error was to:

cd components/licensor/
go get -u golang.org/x/sys
cd -
yarn

Reference: https://stackoverflow.com/a/71508032/11019230

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Sep 9, 2022
@aboqasem
Copy link

Is there any chance the closed PR gets reviewed if updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants