-
Notifications
You must be signed in to change notification settings - Fork 1.3k
refactor(dashboard/new-project): persist selected provider host #10543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for the contribution! |
Glad to help! I have done the CLA now. |
Awesome, many thanks @aboqasem! 🎉 @meysholdt please confirm good reception of CLA. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cool idea! I agree that it's quite tedious to always change the provider host, e.g. when you're adding multiple projects and Gitpod doesn't show you the right provider by default.
The code looks good to me (with one very minor nit). I would also be keen to test it, so I'll trigger a CI build:
/werft run
Ah, the CI doesn't pick up review comments, so let's try this again: /werft run 👍 started the job as gitpod-build-improve-persist-repo-provider-fork.0 |
Thank you for the review @jankeromnes! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…ProviderHost` Co-authored-by: Jan Keromnes <janx@linux.com>
69e4e83
to
f310d85
Compare
hi @aboqasem, and thank you for your contribution. I checked but we don't have a signed CLA from you on file. Can you please sign our CLA via this DocuSign form? If there are any questions, you can reach me via moritz@gitpod.io. |
Thx for signing the CLA! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
/werft run 👍 started the job as gitpod-build-improve-persist-repo-provider-fork.1 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Persist the selected provider locally for better UX.
Related Issue(s)
Fixes #8524
How to test
Release Notes
Documentation
N/A