Skip to content

refactor(dashboard/new-project): persist selected provider host #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aboqasem
Copy link

@aboqasem aboqasem commented Jun 9, 2022

Description

Persist the selected provider locally for better UX.

Related Issue(s)

Fixes #8524

How to test

  1. Open dashboard
  2. Navigate to projects
  3. Click "New Project"
  4. Change the selected provider
  5. Refresh
  6. Repeat 4 and 5 and optionally check local storage to see the host changing

Release Notes

persist selected provider when creating a new project

Documentation

N/A

@aboqasem aboqasem requested a review from a team June 9, 2022 03:07
@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 9, 2022

Thanks a lot for the contribution! ♥️ Flagging this for review.

@aboqasem
Copy link
Author

Glad to help! I have done the CLA now.

@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 10, 2022

Awesome, many thanks @aboqasem! 🎉

@meysholdt please confirm good reception of CLA. 🙏

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cool idea! I agree that it's quite tedious to always change the provider host, e.g. when you're adding multiple projects and Gitpod doesn't show you the right provider by default.

The code looks good to me (with one very minor nit). I would also be keen to test it, so I'll trigger a CI build:

/werft run

@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 10, 2022

Ah, the CI doesn't pick up review comments, so let's try this again:

/werft run

👍 started the job as gitpod-build-improve-persist-repo-provider-fork.0
(with .werft/ from main)

@aboqasem
Copy link
Author

Thank you for the review @jankeromnes!

@stale
Copy link

stale bot commented Jun 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 22, 2022
@stale stale bot closed this Jun 28, 2022
@gtsiolis gtsiolis reopened this Jul 4, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jul 4, 2022
@aboqasem aboqasem force-pushed the improve/persist-repo-provider branch from 69e4e83 to f310d85 Compare July 10, 2022 13:56
@meysholdt
Copy link
Member

hi @aboqasem, and thank you for your contribution. I checked but we don't have a signed CLA from you on file. Can you please sign our CLA via this DocuSign form? If there are any questions, you can reach me via moritz@gitpod.io.

@meysholdt
Copy link
Member

Thx for signing the CLA!

@meysholdt meysholdt added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Jul 26, 2022
@stale
Copy link

stale bot commented Aug 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 10, 2022
@stale stale bot closed this Aug 16, 2022
@gtsiolis gtsiolis reopened this Aug 16, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Aug 16, 2022
@gtsiolis gtsiolis requested a review from jankeromnes August 16, 2022 07:49
@gtsiolis gtsiolis requested review from a team and removed request for jankeromnes August 16, 2022 07:49
@stale
Copy link

stale bot commented Sep 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@svenefftinge
Copy link
Member

  • /werft --with-preview

@svenefftinge svenefftinge removed the meta: stale This issue/PR is stale and will be closed soon label Sep 12, 2022
@svenefftinge
Copy link
Member

svenefftinge commented Sep 12, 2022

/werft run

👍 started the job as gitpod-build-improve-persist-repo-provider-fork.1
(with .werft/ from main)

@stale
Copy link

stale bot commented Sep 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 24, 2022
@stale stale bot closed this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember last user choice for "auth provider" dropdown (client side)
6 participants