refactor(context-menu): scroll into view if needed

[aboqasem]

Description

Scroll context menus into view when needed.

Related Issue(s)

Fixes #9326

How to test

scrollIntoViewIfNeeded.mov

Release Notes

scroll context menus into view when needed

Documentation

[jankeromnes]

Thanks! ♥️ Flagging this for review too.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gtsiolis]

Thanks for contributing, @aboqasem! 🍊

Ideally, we would detect when there isn't enough space in the viewport and position the dropdown above the button when needed, without requiring any scrolling. Do you think this could be easy to change here? Otherwise, we could leave this as is for now as it seems like an improvement and open a follow-up issue to properly resolve this. ❓

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

[aboqasem]

Thank you for your review!

The issue states that scrolling is a possible solution 😅. Regarding the solution you've mentioned, how could the size of the menu be determined without viewing it? Is it by having fixed numbers representing menu item heights on each screen breakpoint and then using it with the number of menu items to determine whether there is available space or not? Or is there something else?

For the CLA, I think I must commit with my email that signed the CLA, not the Github noreply email right?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[meysholdt]

hi @aboqasem and thank you for your contributions! Since I can't find a CLA of you on file, can you please sign one as requested here? thank you!

[meysholdt]

Thx for signing the CLA!

[jankeromnes]

/werft run

👍 started the job as gitpod-build-improve-dropdown-visibilty-fork.0
(with .werft/ from main)

[jankeromnes]

Hi @aboqasem! Many thanks for implementing this fix. 💯 This looks good to me, but I'd love to test it before approving.

In order to test it, I'd need a full build of this Pull Request, however I notice that the build currently fails -- the failure looks unrelated to your changes, but could be caused by your PR being based on an old commit.

Could you please go through the following steps in order to update this PR?

1. Open this PR in Gitpod, e.g. by clicking this link: https://gitpod.io/#https://github.com/gitpod-io/gitpod/pull/10545
2. In the terminal, run these commands:

git pull --rebase upstream main

git push -f origin

This should fix the build and allow me to review and approve your PR. 🙂

[aboqasem]

Hi @jankeromnes! Thank you for the review. I have updated the PR and looking forward to it being merged!

[laushinka]

@jankeromnes Would you like to review it again? Also happy to take it over 🙏🏽

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.