Skip to content

Please make Werft support arbitrarily long branch names #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Mar 4, 2022 · 2 comments
Closed

Please make Werft support arbitrarily long branch names #8605

jankeromnes opened this issue Mar 4, 2022 · 2 comments
Labels
priority: high (dev loop impact) Gitpod development loop impacting issues team: devx

Comments

@jankeromnes
Copy link
Contributor

Bug description

Currently, Werft spontaneously fails your Pull Request if your branch name is not extremely short:

gitpod/.werft/build.ts

Lines 52 to 55 in 73cbeef

const maxBranchNameLength = 20;
if (config.previewEnvironment.destname.length > maxBranchNameLength) {
werft.fail("check-branchname", `The branch name ${config.previewEnvironment.destname} is more than ${maxBranchNameLength} character. Please choose a shorter name!`)
}

The only solution is to pack up your work and move to a completely new branch / Pull Request.

This is becoming a significant tax on Gitpod's developer velocity and happiness:

Could we please find a way to support slightly longer branch names? 🙏 😍 (For example like so)

Steps to reproduce

  1. Contribute to Gitpod
  2. Get frustrated 🤬

Workspace affected

No response

Expected behavior

  1. Contribute to Gitpod
  2. Smooth sailing ⛵

Example repository

https://github.com/gitpod-io/gitpod

Anything else?

No response

@jankeromnes jankeromnes added priority: high (dev loop impact) Gitpod development loop impacting issues team: devx labels Mar 4, 2022
@laushinka
Copy link
Contributor

Steps to reproduce

  1. Contribute to Gitpod
  2. Get frustrated 🤬

🤣

@mads-hartmann
Copy link
Contributor

@jankeromnes I know this is extremely frustrating. We have previously discussed possible solutions here but as this entire problem will go away once we use VM-based preview environments we had so far prioritised getting that into a shape where we can ship them.

However as the beta deadline has slipped and we won't be able to delete core-dev until all teams have migrated to the Installer I believe it's worth trying to fix this. The team is currently split 3/4 working on VMs and 1/4 (me) trying to "keep the fort". I will close this issue in favour of https://github.com/gitpod-io/ops/issues/1252 as it already has all the context and then move it to the current iteration. However as it's only me and there's already a ton on my plate I can't promise that I'll get to it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high (dev loop impact) Gitpod development loop impacting issues team: devx
Projects
No open projects
Development

No branches or pull requests

3 participants