Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename editor preference section heading #7428

Closed
wants to merge 1 commit into from

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jan 3, 2022

Description

This will update the IDE (Editor) preference section heading from Default IDE to Editor.

This can probably be further improved in #6602.

See relevant discussion (internal).

How to test

Go to /preferences.

Release Notes

Rename editor preference section heading

@roboquat
Copy link
Contributor

roboquat commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from gtsiolis and additionally assign jeanp413 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeanp413 in a comment when ready.

Associated issue: #6602

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat added team: IDE team: webapp Issue belongs to the WebApp team size/S labels Jan 3, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 3, 2022

@jeanp413 what do you think of this change?

Took a bias for action and opened this. Feel free to also close if it does not look like a good MVC (minimum viable change) or pick this up if there's more to change. Cc @akosyakov @loujaybee

@gtsiolis gtsiolis requested a review from jeanp413 January 3, 2022 19:28
@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

/werft run

👍 started the job as gitpod-build-gt-rename-editor-preference-section-title.2

@jeanp413 jeanp413 force-pushed the gt/rename-editor-preference-section-title branch from 6e8a3b4 to 15a2e26 Compare January 4, 2022 01:41
@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-gt-rename-editor-preference-section-title.4

@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

/werft run with-helm

👍 started the job as gitpod-build-gt-rename-editor-preference-section-title.5

@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

Changes look fine for me but not sure why the build is failing

@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

/werft run with-clean-slate-deployment with-helm

👍 started the job as gitpod-build-gt-rename-editor-preference-section-title.6

@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-gt-rename-editor-preference-section-title.7

@jeanp413
Copy link
Member

jeanp413 commented Jan 4, 2022

ah I see the branch name is too long. @gtsiolis I think you need to create another PR with a shorter name

[install certs|FAIL] Error: there is no subdomain + 'gt-rename-editor-preference-section-title.staging.gitpod-dev.com' shorter or equal to 63 characters, max. allowed length for CN. No HTTPS certs for you! Consider using a short branch name...
Error Error: there is no subdomain + 'gt-rename-editor-preference-section-title.staging.gitpod-dev.com' shorter or equal to 63 characters, max. allowed length for CN. No HTTPS certs for you! Consider using a short branch name...

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 4, 2022

ah I see the branch name is too long.

Ah, you're right, @jeanp413! I've run into this a couple of times in the past. 😭

Closing this, as I've opened #7437 to continue the discussion there.

@gtsiolis gtsiolis closed this Jan 4, 2022
@gtsiolis gtsiolis deleted the gt/rename-editor-preference-section-title branch May 5, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants